From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50577 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVfLK-0005tw-2G for qemu-devel@nongnu.org; Mon, 05 Jul 2010 02:39:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OVfLG-00077j-9D for qemu-devel@nongnu.org; Mon, 05 Jul 2010 02:39:48 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:36782) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVfLF-00077H-RY for qemu-devel@nongnu.org; Mon, 05 Jul 2010 02:39:46 -0400 Message-ID: <4C317E2A.7090101@web.de> Date: Mon, 05 Jul 2010 08:39:38 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups References: <20100629211802.16137.10587.malonedeb@soybean.canonical.com> <4C2EECE8.8030305@web.de> <201007042306.57852.paul@codesourcery.com> In-Reply-To: <201007042306.57852.paul@codesourcery.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig87ABF5215CE4D4C5E9AB8607" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Blue Swirl , qemu-devel@nongnu.org, Gleb Natapov This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig87ABF5215CE4D4C5E9AB8607 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Paul Brook wrote: >> Blue Swirl wrote: >>> On Sat, Jul 3, 2010 at 7:39 AM, Jan Kiszka wrote:= >>>> Paul Brook wrote: >>>>>> I really see no tangible objection to Jan's patches. They don't >>>>>> impact any other code. They don't inhibit flexibility in the >>>>>> infrastructure. You might consider it to be a "hack" but so what. = >>>>>> QEMU is filled with hacks. It would be useless without them becau= se >>>>>> there would be very little code. >>>>> I object strongly to anything that makes qemu_irq a message passing= >>>>> API. if you want message passing then you should not be using >>>>> qemu_irq. >>>> Blueswirl objected to the straightforward return-value approach I fi= rst >>>> posted. You seems to be more open towards this, right? Still looks l= ike >>>> I cannot make you both happy at the same time. So what to do? >>> I have withdrawn my objection. We can do message passing with some >>> different API later, for simple coalescing needs the return value >>> approach is enough. >> Great! I'll respin my patches ASAP. >=20 > Note that I still have some concerns over the semantics of that API. > I believe this should be fundamentally state based, not event based. For the caller of qemu_set_irq, it will be like that. >=20 > In practice returning a value from qemu_set_irq may be a reasonable way= of=20 > communicating this state. However this should be done is such a a way = that=20 > redundant calls to qemu_set_irq return the same value. I played with ignoring redundant invocations of qemu_set_irq early to strengthen the state based concept. Unfortunately, the result was a non-booting x86 system as at least the PIT is not properly deasserting its IRQ line in periodic mode. Everything is fixable, I'm just reluctant to overload the planned series with such a measure. I would prefer doing this in a second step after checking for more such regressions. >=20 > See http://lists.nongnu.org/archive/html/qemu-devel/2010-06/msg01592.ht= ml Will adopt the naming scheme. Jan --------------enig87ABF5215CE4D4C5E9AB8607 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkwxfi4ACgkQitSsb3rl5xRiFwCgvJOGixXH0mfLooHwteDJL1eO +hIAoOlp4P7evGAinav+EwBP3FltPxnf =AgFE -----END PGP SIGNATURE----- --------------enig87ABF5215CE4D4C5E9AB8607--