From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] egiga: remove references to kirkwood SoC
Date: Mon, 05 Jul 2010 13:41:36 +0200 [thread overview]
Message-ID: <4C31C4F0.6070104@free.fr> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19A4A5CC58@SC-VEXCH4.marvell.com>
Le 05/07/2010 13:02, Prafulla Wadaskar a ?crit :
>> -----Original Message-----
>> From: u-boot-bounces at lists.denx.de
>> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
>> Sent: Friday, July 02, 2010 10:23 PM
>> To: u-boot at lists.denx.de
>> Subject: [U-Boot] [PATCH 3/4] egiga: remove references to kirkwood SoC
>>
>> Macros, types, variables, functions in egiga
>> refer to kirkwood even though they are not
>> kirkwood-specific. Rename them, across the
>> whole source tree when necessary.
>
> NAK, as commented for Patch 1/4
> you can address it more like splitting a driver into generic and specific interfaces
> and then adding new support
I'm not sure I get your meaning here. Do you suggest I submit not four
but only two patches, one with all egiga-out-of-kirkwood changes and one
with orion5x support? Or is is something else entirely?
> Regards..
> Prafulla ..
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-07-05 11:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 16:53 [U-Boot] [PATCH 0/4] make egiga common to kirkwood and orion5x Albert Aribaud
2010-07-02 16:53 ` [U-Boot] [PATCH 1/4] ARM: Rename kirkwood_egiga driver to egiga Albert Aribaud
2010-07-02 16:53 ` [U-Boot] [PATCH 2/4] egiga: Remove functional dependency on kirkwood Albert Aribaud
2010-07-02 16:53 ` [U-Boot] [PATCH 3/4] egiga: remove references to kirkwood SoC Albert Aribaud
2010-07-02 16:53 ` [U-Boot] [PATCH 4/4] egiga: add support for orion5x Albert Aribaud
2010-07-05 11:01 ` Prafulla Wadaskar
2010-07-05 11:02 ` [U-Boot] [PATCH 3/4] egiga: remove references to kirkwood SoC Prafulla Wadaskar
2010-07-05 11:41 ` Albert ARIBAUD [this message]
2010-07-05 12:02 ` Prafulla Wadaskar
2010-07-05 11:03 ` [U-Boot] [PATCH 2/4] egiga: Remove functional dependency on kirkwood Prafulla Wadaskar
2010-07-05 17:59 ` Albert ARIBAUD
2010-07-05 19:54 ` Prafulla Wadaskar
2010-07-02 17:20 ` [U-Boot] [PATCH 1/4] ARM: Rename kirkwood_egiga driver to egiga Ben Warren
2010-07-02 17:27 ` Albert ARIBAUD
2010-07-05 11:02 ` Prafulla Wadaskar
2010-07-05 11:36 ` Albert ARIBAUD
2010-07-05 12:01 ` Prafulla Wadaskar
2010-07-05 13:15 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C31C4F0.6070104@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.