From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37975 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OVo5l-0008To-NT
	for qemu-devel@nongnu.org; Mon, 05 Jul 2010 12:00:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OVo5k-0006Q0-LG
	for qemu-devel@nongnu.org; Mon, 05 Jul 2010 12:00:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46277)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OVo5k-0006Pk-El
	for qemu-devel@nongnu.org; Mon, 05 Jul 2010 12:00:20 -0400
Message-ID: <4C320186.3080804@redhat.com>
Date: Mon, 05 Jul 2010 18:00:06 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1277898942-6501-1-git-send-email-armbru@redhat.com>
	<1277898942-6501-9-git-send-email-armbru@redhat.com>
In-Reply-To: <1277898942-6501-9-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 08/11] ide: Replace IDEState members
 is_cdrom, is_cf by drive_kind
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com

Am 30.06.2010 13:55, schrieb Markus Armbruster:
> The two aren't independent variables.  Make that obvious.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Can we please call the constant IDE_CDROM or something else that is easy
to distinguish? With this patch, we have IDE_CD and IDE_CF, which is an
easy typo to make.

Kevin