From: Mark Lord <kernel@teksavvy.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH 4/4] libata: allow hyphenated pattern ranges
Date: Mon, 05 Jul 2010 17:47:43 -0400 [thread overview]
Message-ID: <4C3252FF.3040501@teksavvy.com> (raw)
In-Reply-To: <4C322585.602@pobox.com>
On 05/07/10 02:33 PM, Jeff Garzik wrote:
> On 07/05/2010 10:25 AM, Mark Lord wrote:
>> Enable use of hyphenated pattern ranges in glob_match(), similar to how
>> shell globbing works, and how developers might expect things to work.
>>
>> Signed-off-by: Mark Lord <mlord@pobox.com>
>> ---
>>
>> Patch also attached, to get around ongoing mailer issues here.
>> Eventually, glob_match() will move out of libata into lib/string.c or
>> similar.
>
> No issue with correctness... but where is the demonstrated need?
>
> Did someone ask for this?
..
Not specifically. But since this will eventually end up as a kernel-wide
library function, somebody somewhere will eventually make the reasonable
assumption that it does globbing "in the usual way".
Adding the hyphenated ranges turned out to be almost trivial,
so I added it on and posted the patch.
I could also send you follow-on patches to use that feature
in the ata blacklists, if you like, saving a few more bytes hither and dither. :)
Speaking of this stuff.. how do we go about moving this function to /lib/strings.c ?
Can that be done via your git tree?
Thanks
next prev parent reply other threads:[~2010-07-05 21:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 15:30 [PATCH 1/3] libata: glob_match for ata_device_blacklist Mark Lord
2010-07-01 15:31 ` [PATCH 2/3] libata: reduce blacklist size Mark Lord
2010-07-01 15:31 ` [PATCH 3/3] libata: reduce blacklist size even more Mark Lord
2010-07-01 15:36 ` [PATCH 3/3] libata: reduce blacklist size (resend) Mark Lord
2010-07-01 15:34 ` [PATCH 1/3] libata: glob_match for ata_device_blacklist Mark Lord
2010-07-01 15:36 ` James Bottomley
2010-07-01 15:44 ` Mark Lord
2010-07-01 19:24 ` Jeff Garzik
2010-07-01 21:56 ` Mark Lord
2010-07-01 22:09 ` Mark Lord
2010-07-01 22:16 ` [PATCH 1/3] libata: glob_match for ata_device_blacklist (v2) Mark Lord
2010-07-01 22:17 ` [PATCH 2/3] libata: reduce blacklist size (v2) Mark Lord
2010-07-01 22:18 ` [PATCH 3/3] libata: reduce blacklist size even more (v2) Mark Lord
2010-07-02 7:19 ` Jeff Garzik
2010-07-05 14:25 ` [PATCH 4/4] libata: allow hyphenated pattern ranges Mark Lord
2010-07-05 18:33 ` Jeff Garzik
2010-07-05 21:47 ` Mark Lord [this message]
2010-07-05 22:20 ` Jeff Garzik
2010-07-05 22:39 ` Mark Lord
2010-07-05 22:50 ` [PATCH 5/5] " Mark Lord
2010-07-05 22:51 ` Mark Lord
2010-07-05 22:53 ` [PATCH 5/5] libata: allow hyphenated pattern ranges (v2) Mark Lord
2010-07-14 7:54 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3252FF.3040501@teksavvy.com \
--to=kernel@teksavvy.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.