All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Andreas Dilger <adilger@dilger.ca>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: extent counting fun
Date: Mon, 05 Jul 2010 19:50:08 -0500	[thread overview]
Message-ID: <4C327DC0.4070305@redhat.com> (raw)
In-Reply-To: <AF4CA4E6-4ADE-41E3-843D-02266228E2CB@dilger.ca>

Andreas Dilger wrote:
> On 2010-07-05, at 13:24, Eric Sandeen wrote:
>> [root@host ~]# filefrag -B /mnt/test/file
>> /mnt/test/file: 34 extents found
>> [root@host ~]# filefrag /mnt/test/file
>> /mnt/test/file: 1058 extents found, perfection would be 1 extent
>>
>> Hum, is it 34 or 1058? :)
> 
> What do the extents look like on disk?  Is this just because it is running on a block-mapped file and is skipping a singleton block periodically for indirect blocks, or is there a bug in the way the extents are being reported?

Well, I didn't actually look but I'm 98% sure it's just because it's
not reporting the interspersed metadata blocks.

Sorry, above was on ext3, that wasn't clear, just a stock dd-streamed
file.

>> Older filefrag counted contiguous metadata as part of a contiguous
>> extent... newer filefrag works in fiemap query-only mode by default,
>> and just takes what fiemap tells it.  The inconsistency is weird
>> though, and led to a Red Hat bug that I'm inclined to NOTABUG... but
>> do people think this needs to be made any more consistent?
>>
>> Should we hack ext3_fiemap() to include the checks for contiguous
>> metadata?  Or was that too shady/clever to start with ...? :)
> 
> I wouldn't object to having FIEMAP add a flag for metadata blocks.  I've always thought it would be useful to be able to query/dump metadata blocks (e.g. indirect/index blocks) and the inode itself.

Hm don't we have that already?

Hmm... just xattr I guess.

In any case it's still a question of whether ext3 extent count should
be "fudged" to make blocks separated by metadata look contiguous
or not ...

-Eric

> Cheers, Andreas
> 
> 
> 
> 
> 


  reply	other threads:[~2010-07-06  0:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-05 19:24 extent counting fun Eric Sandeen
2010-07-05 23:46 ` Andreas Dilger
2010-07-06  0:50   ` Eric Sandeen [this message]
2010-07-09 21:10     ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C327DC0.4070305@redhat.com \
    --to=sandeen@redhat.com \
    --cc=adilger@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.