From: Clemens Ladisch <clemens@ladisch.de>
To: "Soeren D. Schulze" <soeren.d.schulze@gmx.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: Still unhappy with removal of DXS controls
Date: Tue, 06 Jul 2010 12:37:06 +0200 [thread overview]
Message-ID: <4C330752.3090201@ladisch.de> (raw)
In-Reply-To: <4C3234C1.2060901@gmx.de>
Soeren D. Schulze wrote:
> Please, even if the solution with the DXS controls in alsamixer didn't
> comply with the ALSA policies, *it did work*! The current one *does
> not*. Maybe make the maximum (or default?) DXS volume available as a
> mixer control or as a module option or something -- whatever you
> consider the best solution.
Please try this patch:
--- a/sound/pci/via82xx.c
+++ b/sound/pci/via82xx.c
@@ -85,6 +85,7 @@ static int joystick;
static int ac97_clock = 48000;
static char *ac97_quirk;
static int dxs_support;
+static int dxs_init_volume = 31;
static int nodelay;
module_param(index, int, 0444);
@@ -103,6 +104,8 @@ module_param(ac97_quirk, charp, 0444);
MODULE_PARM_DESC(ac97_quirk, "AC'97 workaround for strange hardware.");
module_param(dxs_support, int, 0444);
MODULE_PARM_DESC(dxs_support, "Support for DXS channels (0 = auto, 1 = enable, 2 = disable, 3 = 48k only, 4 = no VRA, 5 = enable any sample rate)");
+module_param(dxs_init_volume, int, 0644);
+MODULE_PARM_DESC(dxs_init_volume, "initial DXS volume (0-31)");
module_param(nodelay, int, 0444);
MODULE_PARM_DESC(nodelay, "Disable 500ms init delay");
@@ -1245,8 +1248,10 @@ static int snd_via8233_playback_open(struct snd_pcm_substream *substream)
return err;
stream = viadev->reg_offset / 0x10;
if (chip->dxs_controls[stream]) {
- chip->playback_volume[stream][0] = 0;
+ chip->playback_volume[stream][0] =
+ VIA_DXS_MAX_VOLUME - (dxs_init_volume & 31);
- chip->playback_volume[stream][1] = 0;
+ chip->playback_volume[stream][1] =
+ VIA_DXS_MAX_VOLUME - (dxs_init_volume & 31);
chip->dxs_controls[stream]->vd[0].access &=
~SNDRV_CTL_ELEM_ACCESS_INACTIVE;
snd_ctl_notify(chip->card, SNDRV_CTL_EVENT_MASK_VALUE |
next prev parent reply other threads:[~2010-07-06 10:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 19:38 Still unhappy with removal of DXS controls Soeren D. Schulze
2010-07-05 22:25 ` Raymond Yau
2010-07-06 10:37 ` Clemens Ladisch [this message]
2010-07-06 20:43 ` Soeren D. Schulze
2010-07-07 13:01 ` Clemens Ladisch
2010-07-07 15:30 ` Soeren D. Schulze
2010-07-08 4:28 ` Raymond Yau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C330752.3090201@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=soeren.d.schulze@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.