Re: [PATCH 5/6] KVM: x86 emulator: fix 'mov AL,moffs' instruction decoding

[Avi Kivity <avi@redhat.com>]

On 07/06/2010 11:53 AM, Wei Yongjun wrote:
> 'mov AL,moffs' do not need decode dest operand and
> 'mov moffs,AL' do not need decode source operand.
>
>
> @@ -177,8 +177,8 @@ static u32 opcode_table[256] = {
>  	0, 0, SrcImmFAddr | No64, 0,
>  	ImplicitOps | Stack, ImplicitOps | Stack, 0, 0,
>  	/* 0xA0 - 0xA7 */
> -	ByteOp | DstReg | SrcMem | Mov | MemAbs, DstReg | SrcMem | Mov | MemAbs,
> -	ByteOp | DstMem | SrcReg | Mov | MemAbs, DstMem | SrcReg | Mov | MemAbs,
> +	ByteOp | SrcMem | Mov | MemAbs, SrcMem | Mov | MemAbs,
> +	ByteOp | DstMem | Mov | MemAbs, DstMem | Mov | MemAbs,
>  	ByteOp | SrcSI | DstDI | Mov | String, SrcSI | DstDI | Mov | String,
>  	ByteOp | SrcSI | DstDI | String, SrcSI | DstDI | String,
>  	/* 0xA8 - 0xAF */
>   

Autotest rejected this patch (Windows XP fails to install). I think the
reason is that without DstReg, op->type is not initialized and writeback
fails.

I dropped this patch. Suggest re-implementing with DstAcc and (new) SrcAcc.

-- 
error compiling committee.c: too many arguments to function