From: Boaz Harrosh <bharrosh@panasas.com>
To: Fred Isaman <iisaman@netapp.com>
Cc: Benny Halevy <bhalevy@panasas.com>,
Andy Adamson <andros@netapp.com>,
pNFS Mailing List <pnfs@linux-nfs.org>,
NFS list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/6] SQUASME pnfs-submit: Collapse pnfs_try_to_write_data code path and avoid big fat inlines
Date: Tue, 06 Jul 2010 17:46:44 +0300 [thread overview]
Message-ID: <4C3341D4.3020000@panasas.com> (raw)
In-Reply-To: <264D5500-73A1-4315-9182-D21A6D2141FD@netapp.com>
On 07/06/2010 05:31 PM, Fred Isaman wrote:
>
> On Jul 6, 2010, at 9:55 AM, Boaz Harrosh wrote:
>
<snip>
>> @@ -1547,9 +1548,8 @@ pnfs_writepages(struct nfs_write_data *wdata, int how)
>> numpages = nfs_page_array_len(args->pgbase, args->count);
>>
>> dprintk("%s: Calling layout driver (how %d) write with %d pages\n",
>> - __func__,
>> - how,
>> - numpages);
>> + __func__, how, numpages);
>> +
>> if (!pnfs_use_rpc(nfss))
>> wdata->pdata.pnfsflags |= PNFS_NO_RPC;
>
> Just curious, what branch is this based on? The above code was removed in the pnfs-submit branches a while ago.
>
> Other than that, looks good.
>
It's over pnfs-all-latest because for me I need the bigger tree for actually testing
my code. So more work for Benny when squashing to sort out the hunks.
But if it was removed what patch brings it back, this is odd. Benny?
> Fred
>
Boaz
next prev parent reply other threads:[~2010-07-06 14:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 13:51 [PATCH 0/6] Some pnfs-submit love Boaz Harrosh
2010-07-06 13:56 ` [PATCH 1/6] SQUASME pnfs-submit: Collapse pnfs_try_to_write_data code path and avoid big fat inlines Boaz Harrosh
2010-07-06 13:57 ` [PATCH 2/6] SQUASME pnfs-submit: Collapse pnfs_try_to_read_data " Boaz Harrosh
2010-07-06 14:05 ` [PATCH 3/6] SQUASME pnfs-submit: Collapse pnfs_try_to_commit " Boaz Harrosh
2010-07-06 14:06 ` [PATCH 4/6] SQUASHME: pnfs-submit: Move _pnfs_clear_lseg_from_pages to pnfs.c Boaz Harrosh
2010-07-06 14:07 ` [PATCH 5/6] SQUASHME: pnfs-commit: Fix scariness in nfs4_clear_inode Boaz Harrosh
2010-07-06 14:08 ` [PATCH 6/6] SQUASHME: pnfs-submit: pnfs_return_layout remove surrounding #ifdef CONFIG_NFS_V4_1 Boaz Harrosh
[not found] ` <1278424509-22230-1-git-send-email-bharrosh@panasas.com>
[not found] ` <264D5500-73A1-4315-9182-D21A6D2141FD@netapp.com>
2010-07-06 14:46 ` Boaz Harrosh [this message]
2010-07-06 14:57 ` [PATCH 1/6] SQUASME pnfs-submit: Collapse pnfs_try_to_write_data code path and avoid big fat inlines Fred Isaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3341D4.3020000@panasas.com \
--to=bharrosh@panasas.com \
--cc=andros@netapp.com \
--cc=bhalevy@panasas.com \
--cc=iisaman@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.