All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jes.Sorensen@redhat.com
Cc: frank.arnold@amd.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] Include sys/mman.h before qemu-options.h
Date: Tue, 06 Jul 2010 10:46:59 -0500	[thread overview]
Message-ID: <4C334FF3.9080707@codemonkey.ws> (raw)
In-Reply-To: <1278406227-27774-2-git-send-email-Jes.Sorensen@redhat.com>

On 07/06/2010 03:50 AM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> The result of parsing qemu-options.def depends on whehter or not
> MAP_POPULATE is defined, so make sure to include sys/mman.h before
> including qemu-options.h.
>
> Reported by Frank Arnold.
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   os-posix.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/os-posix.c b/os-posix.c
> index 804e20c..00133a0 100644
> --- a/os-posix.c
> +++ b/os-posix.c
> @@ -28,6 +28,8 @@
>   #include<signal.h>
>   #include<sys/types.h>
>   #include<sys/wait.h>
> +/*needed for MAP_POPULATE before including qemu-options.h */
> +#include<sys/mman.h>
>   #include<pwd.h>
>   #include<libgen.h>
>
>    

      reply	other threads:[~2010-07-06 15:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-06  8:50 [Qemu-devel] [PATCH 0/1] Fix qemu-options enum (repost) Jes.Sorensen
2010-07-06  8:50 ` [Qemu-devel] [PATCH 1/1] Include sys/mman.h before qemu-options.h Jes.Sorensen
2010-07-06 15:46   ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C334FF3.9080707@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=Jes.Sorensen@redhat.com \
    --cc=frank.arnold@amd.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.