From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53719 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OWATy-0003YP-N7
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 11:54:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OWATu-0003oI-KH
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 11:54:47 -0400
Received: from goliath.siemens.de ([192.35.17.28]:20432)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OWATu-0003ng-A9
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 11:54:46 -0400
Message-ID: <4C3351BB.9000709@siemens.com>
Date: Tue, 06 Jul 2010 17:54:35 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f
References: <4C32EBEC.9010204@bandsman.co.uk> <4C32EE35.2040607@siemens.com>
	<4C334FEC.4000604@codemonkey.ws>
In-Reply-To: <4C334FEC.4000604@codemonkey.ws>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Nigel Horne <njh@bandsman.co.uk>, Paolo Bonzini <pbonzini@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Anthony Liguori wrote:
> On 07/06/2010 03:49 AM, Jan Kiszka wrote:
>> Nigel Horne wrote:
>>   =20
>>> ./configure --enable-linux-aio --enable-io-thread --enable-kvm
>>> make
>>> ...
>>> /home/njh/src/qemu/cpus.c:532: error: =91exit_request=92 undeclared (=
first
>>> use in this function)
>>> /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is
>>> reported only once
>>> /home/njh/src/qemu/cpus.c:532: error: for each function it appears in=
.)
>>>
>>> Perhaps cpus.c needs to have:
>>>
>>> extern volatile sig_atomic_t exit_request;
>>>     =20
>> Better include the header:
>>
>> ---------->
>>
>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>>   =20
>=20
> Applied.  Thanks.
>=20
> In the future, please try to avoid quoting in like this.  I often forge=
t=20
> to remove it from the commit message before pushing (although I did in=20
> this case).

OK.

Note that there is also 'git am -c' - but I used a non-standard scissors
line here...

Jan

--=20
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux