Re: [PATCH] fix for consistency errors after crash

[Eric Sandeen <sandeen@redhat.com>]

Amir G. wrote:
> Hi Eric,
> 
> I've seen you guys had some open RH bugs on ext3, who all share in
> common the "bit already free" error.
> 
> This bug I reported can explain many different problems in ext[34].
> 
> Essentially, every time there is a kernel crash (or hard reboot)
> during delete/truncate of a large file,
> it may result in "bit already clear" error after reboot.
> 
> The problem is very simple and so is the fix.
> I proved the problem with 100% recreation chances using a small patch,
> instead of running statistical stress tests.
> All I did was to add a print and 10 seconds delay after transaction
> restart in ext3_free_branches and reboot > 5 seconds after the
> transaction restarts, so that kjournald will have time to commit the
> old transaction.
> After the reboot, I always get "bit already clear" errors, because the
> "half large truncate" transaction is not handled properly.
> 
> I did not get any response from ext4 guys so far and since this bug
> dates back to ext3,
> I was hoping you guys could take a look and put your weight on pushing
> the fix upstream.

Hi Amir, I really do appreciate the effort, the patch, and the ping.  :)

I'll have to set aside some time to give it a hard look, but linking
it back to existing bugs of mine raises that priority, thanks.  :)

-Eric

> Thanks,
> Amir.