From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55027 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OWE0Y-0003B1-AB
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 15:40:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OWE0X-0007Pg-An
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 15:40:42 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:59588)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OWE0X-0007PU-5A
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 15:40:41 -0400
Received: by pvg7 with SMTP id 7so190473pvg.4
	for <qemu-devel@nongnu.org>; Tue, 06 Jul 2010 12:40:39 -0700 (PDT)
Message-ID: <4C3386A3.6090605@codemonkey.ws>
Date: Tue, 06 Jul 2010 14:40:19 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Makefile: Fix compilation for non-standard
	host kernel path
References: <4C2DCA61.2080501@linux.vnet.ibm.com>
In-Reply-To: <4C2DCA61.2080501@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Prerna Saxena <prerna@linux.vnet.ibm.com>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org

On 07/02/2010 06:15 AM, Prerna Saxena wrote:
> Set up host kernel include paths specified by --kerneldir
>
> When host kernel headers are placed in non-standard paths, the
> KVM_CFLAGS are presently invoked only for a few .c files 
> (kvm*.c,vhost*.c) and not for other files like machine.c, cpus.c
>  ..etc which also depend on linux/kvm.h

I think that's a bug.  What's the dependency of machine.c and cpus.c?

Regards,

Anthony Liguori

>
> Signed-off-by: Prerna Saxena <prerna@linux.vnet.ibm.com>
> ---
>  Makefile.target |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index d58b201..b433112 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -29,12 +29,15 @@ QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
>  endif
>  endif
>
> +# Set up host kernel include paths specified by --kerneldir
> +ifdef CONFIG_KVM
> +QEMU_CFLAGS+=$(KVM_CFLAGS)
> +endif
> +
>  PROGS=$(QEMU_PROG)
>
>  LIBS+=-lm
>
> -kvm.o kvm-all.o vhost.o vhost_net.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
> -
>  config-target.h: config-target.h-timestamp
>  config-target.h-timestamp: config-target.mak
>