All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Chris Li <lkml@chrisli.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Matthew Wilcox <willy@linux.intel.com>
Subject: Re: BUG in drivers/dma/ioat/dma_v2.c:314
Date: Tue, 06 Jul 2010 17:58:11 -0700	[thread overview]
Message-ID: <4C33D123.4080209@intel.com> (raw)
In-Reply-To: <AANLkTilnrdghkK1y7vc2Zi0C7KMXHYXpI_whecRxTD_8@mail.gmail.com>

On 7/6/2010 5:51 PM, Chris Li wrote:
> On Tue, Jul 6, 2010 at 5:51 PM, Dan Williams<dan.j.williams@intel.com>  wrote:
>> No, it should be PCI_DEVICE_ID_INTEL_IOAT_SNB (0x402f) for the dma
>> engine at 00:0f.0 .  PCI_DEVICE_ID_INTEL_ESB2_0 is the LPC controller at
>> 00:1f.0,
>>
>>> That seems to be the reason preventing the warning to be print out. I am not
>>> sure the warning should be always print out. Just curious why it did
>>> not trigger.
>>
>> It should always trigger, and I have verified as much with the attached
>> replacement patch (by forcing the error on a working system), but we run
>> into a new problem.  dma_pool_alloc() assumes that any dma_mapping error
>> is transient.  Do we need a new type of dma_mapping_error() that
>> indicates permanent failure versus ENOMEM?  The driver can handle the
>> allocation failure, but it never gets the chance.
>
> Should I test your V2 patch instead?
>

It would confirm that we are catching the BIOS misconfiguration, but 
your system will get stuck in this loop.  So just make sure you can get 
back to a working config, which it sounds like you can.

--
Dan




  reply	other threads:[~2010-07-07  0:58 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-28 23:50 BUG in drivers/dma/ioat/dma_v2.c:314 Chris Li
2010-06-29  0:45 ` Dan Williams
2010-06-29  7:17   ` Chris Li
2010-06-29 23:20   ` Chris Li
2010-06-29 23:57     ` Dan Williams
2010-06-30  1:07       ` Chris Li
2010-06-30  4:17         ` Dan Williams
2010-06-30 18:26           ` Chris Li
2010-06-30 18:43             ` Chris Li
2010-06-30 18:43             ` David Woodhouse
2010-06-30 19:40               ` Dan Williams
2010-06-30 20:02                 ` David Woodhouse
2010-06-30 21:44                   ` Dan Williams
2010-06-30 21:59                     ` Chris Li
2010-06-30 22:04                       ` Dan Williams
2010-07-01  6:21                     ` David Woodhouse
2010-07-01  6:51                       ` Dan Williams
2010-07-01  7:12                         ` David Woodhouse
2010-07-01  7:26                           ` Dan Williams
2010-07-01  8:15                             ` David Woodhouse
2010-07-01 17:20                               ` Dan Williams
2010-07-01 17:58                                 ` Chris Li
2010-07-02 19:00                                   ` Chris Li
2010-07-05 10:16                                     ` David Woodhouse
2010-07-06 23:40                                       ` Chris Li
2010-07-07  0:51                                         ` Dan Williams
2010-07-07  0:51                                           ` Chris Li
2010-07-07  0:58                                             ` Dan Williams [this message]
2010-07-07  1:03                                               ` Chris Li
2010-07-07  3:22                                                 ` David Woodhouse
2010-07-07  3:40                                           ` David Woodhouse
2010-07-07 17:47                                             ` Dan Williams
2010-07-07 18:07                                               ` David Woodhouse
2010-07-07 21:56                                               ` Chris Li
2010-07-09 21:28                                                 ` Dan Williams
2010-07-09 22:00                                                   ` Chris Li
2010-07-10  0:09                                                   ` David Woodhouse
2010-07-15  5:41                                                     ` Dan Williams
2010-07-16 21:29                                                       ` Chris Li
2010-07-16 22:12                                                       ` David Woodhouse
2010-07-16 22:40                                                         ` Chris Li
2010-07-22  1:15                                                           ` Dan Williams
2010-07-22 21:39                                                             ` Chris Li
2010-07-22 22:00                                                               ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C33D123.4080209@intel.com \
    --to=dan.j.williams@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@chrisli.org \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.