All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prerna Saxena <prerna@linux.vnet.ibm.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: blauwirbel@gmail.com, Maneesh Soni <maneesh@linux.vnet.ibm.com>,
	Ananth <ananth@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Makefile: Fix compilation for non-standard host kernel path
Date: Wed, 07 Jul 2010 13:56:07 +0530	[thread overview]
Message-ID: <4C343A1F.4010703@linux.vnet.ibm.com> (raw)
In-Reply-To: <4C3386A3.6090605@codemonkey.ws>

On 07/07/2010 01:10 AM, Anthony Liguori wrote:
> On 07/02/2010 06:15 AM, Prerna Saxena wrote:
>> Set up host kernel include paths specified by --kerneldir
>>
>> When host kernel headers are placed in non-standard paths, the
>> KVM_CFLAGS are presently invoked only for a few .c files
>> (kvm*.c,vhost*.c) and not for other files like machine.c, cpus.c
>> ..etc which also depend on linux/kvm.h
>
> I think that's a bug. What's the dependency of machine.c and cpus.c?
>

Both machine.d and cpus.d depend on qemu/kvm.h, which in turn needs 
linux/kvm.h

I am running a custom-compiled kernel for which the headers are placed 
separately. I pass the kernel source directory to my configure script as 
follows :

[usr@zephyr ~]$ configure --prefix=/home/bloat/qemu-git/qemu-bin 
--enable-kvm --target-list=i386-softmmu,x86_64-softmmu --enable-profiler 
--disable-docs --kerneldir=/home/bloat/kernels/linux-2.6.35-rc3
[usr@zephyr ~]$ make -j2

This is one of the errors I get : (similar ones are flagged for 
machine.o and cpus.o)

CC    i386-softmmu/arch_init.o
In file included from /home/bloat/qemu-git/qemu/arch_init.c:38:
/home/bloat/qemu-git/qemu/kvm.h:22:23: error: linux/kvm.h: No such file 
or directory
make[1]: *** [arch_init.o] Error 1

This is because the location of kernel headers is not passed as a '-I' 
switch to gcc. IMO adding the KVM_CFLAGS to QEMU_CFLAGS would be 
required for such cases.

Regards,
-- 
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India

      reply	other threads:[~2010-07-07  8:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02 11:15 [Qemu-devel] [PATCH] Makefile: Fix compilation for non-standard host kernel path Prerna Saxena
2010-07-06 19:40 ` Anthony Liguori
2010-07-07  8:26   ` Prerna Saxena [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C343A1F.4010703@linux.vnet.ibm.com \
    --to=prerna@linux.vnet.ibm.com \
    --cc=ananth@linux.vnet.ibm.com \
    --cc=anthony@codemonkey.ws \
    --cc=blauwirbel@gmail.com \
    --cc=maneesh@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.