From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kraxel@redhat.com, Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2 03/13] raw-posix: Fix test for host CD-ROM
Date: Wed, 07 Jul 2010 12:06:31 +0200 [thread overview]
Message-ID: <4C3451A7.8060207@redhat.com> (raw)
In-Reply-To: <m37hl7prdi.fsf@blackfin.pond.sub.org>
Am 07.07.2010 11:34, schrieb Markus Armbruster:
> Christoph Hellwig <hch@lst.de> writes:
>
>> On Tue, Jul 06, 2010 at 02:08:46PM +0200, Markus Armbruster wrote:
>>> * Any drive backed by host_floppy now retries.
>>
>> I would really prefer not to change the behaviour for this case, it'll
>> just confuse people looking at the history when finally removing this
>> hack.
>
> I'm fine either way. Kevin?
I don't really care about floppies, and I doubt anyone does. Retaining
old behaviour should never be wrong, so if you prefer, I'm okay with it.
Kevin
next prev parent reply other threads:[~2010-07-07 10:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 12:08 [Qemu-devel] [PATCH v2 00/13] Still more block related fixes and cleanups Markus Armbruster
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 01/13] blockdev: Clean up how readonly persists across virtual media change Markus Armbruster
2010-07-07 1:19 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 02/13] block migration: Fix test for read-only drive Markus Armbruster
2010-07-07 1:19 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 03/13] raw-posix: Fix test for host CD-ROM Markus Armbruster
2010-07-07 1:23 ` [Qemu-devel] " Christoph Hellwig
2010-07-07 9:34 ` Markus Armbruster
2010-07-07 10:06 ` Kevin Wolf [this message]
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 04/13] fdc: Reject unimplemented error actions Markus Armbruster
2010-07-07 1:23 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 05/13] qdev: Don't hw_error() in qdev_init_nofail() Markus Armbruster
2010-07-07 1:24 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 06/13] scsi: Reject unimplemented error actions Markus Armbruster
2010-07-07 1:26 ` [Qemu-devel] " Christoph Hellwig
2010-07-07 9:41 ` Markus Armbruster
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 07/13] error: New qemu_opts_loc_restore() Markus Armbruster
2010-07-07 1:26 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 08/13] scsi: Error locations for -drive if=scsi device initialization Markus Armbruster
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 09/13] ide: Improve error messages Markus Armbruster
2010-07-07 1:26 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 10/13] ide: Replace IDEState members is_cdrom, is_cf by drive_kind Markus Armbruster
2010-07-07 1:27 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 11/13] ide: Make ide_init_drive() return success Markus Armbruster
2010-07-07 1:28 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 12/13] ide: Reject readonly drives unless CD-ROM Markus Armbruster
2010-07-07 1:28 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:08 ` [Qemu-devel] [PATCH v2 13/13] ide: Reject invalid CHS geometry Markus Armbruster
2010-07-07 1:28 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 14:06 ` [Qemu-devel] Re: [PATCH v2 00/13] Still more block related fixes and cleanups Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3451A7.8060207@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=hch@lst.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.