All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Felix Homann <fexpop@web.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH - Fix Fast Track Ultra series: 44.1/88.1 kHz 1/Fix playback/capture issues and related chrashes at 44100 Hz and 88200 Hz for M-Audio Fast Track Ultra series.
Date: Wed, 07 Jul 2010 14:44:45 +0200	[thread overview]
Message-ID: <4C3476BD.4090702@ladisch.de> (raw)
In-Reply-To: <4C344340.8060804@web.de>

Felix Homann wrote:
> This fixes issues with M-Audio's Fast Track Ultra series:
> 
> * devices now work at 44100 and 88200 Hz

The descriptors already list these rates, so in theory, the existing
code that sets UAC_EP_CS_ATTR_SAMPLE_RATE should already have enabled
this.  Didn't it?  In other words, what is the difference in the
explicitly specified audioformat?

(I have the suspicion that we don't actually need a AUDIO_FIXED_ENDPOINT
quirk for these devices.)

> * apparently, fixes some crashes, too

When do these crashes happen?

> This is based on a patch posted by user 'dhubsith' on the M-Audio user 
> forum.

If you don't have the exclusive copyright for the code in this patch,
there needs to be a Signed-off-by line from him, too.  OTOH, a table
like this probably isn't copyrightable at all.

> -	USB_DEVICE(0x0763, 0x2080),
> +		USB_DEVICE(0x0763, 0x2081),
> ...

This replaces the ID of the Ultra 8 ID with that of the Ultra 8R ...

>  	USB_DEVICE(0x0763, 0x2081),
> -	.driver_info = ...
> +		.driver_info = ...

... and this just changes the other 8R entry.  So now the 8 doesn't
have an entry.


Regards,
Clemens

  reply	other threads:[~2010-07-07 12:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-06  8:05 [PATCH - Fix Fast Track Ultra series: 44.1/88.1 kHz 1/Fix playback/capture issues and related chrashes at 44100 Hz and 88200 Hz for M-Audio Fast Track Ultra series Felix Homann
2010-07-07  9:05 ` Felix Homann
2010-07-07 12:44   ` Clemens Ladisch [this message]
2010-07-07 13:19     ` Felix Homann
2010-07-07 13:59       ` Felix Homann
2010-07-07 14:23       ` Clemens Ladisch
2010-07-07 16:55         ` Felix Homann
2010-07-08  6:25           ` Clemens Ladisch
2010-07-08  8:35             ` Felix Homann
2010-07-08 13:10               ` Clemens Ladisch
2010-07-08 15:14                 ` Felix Homann
2010-07-08 15:19                   ` Clemens Ladisch
2010-07-08 15:54                     ` Felix Homann
2010-07-16  8:27         ` Felix Homann
2010-08-31  6:39 ` Felix Homann
2010-08-31  8:24   ` [PATCH] - Fix Fast Track Ultra series: 44.1/88.1 kHz 1/Fix playback/capture issues and related crashes " Paul Menzel
2010-09-01  8:48 ` [RESENT] [PATCH - Fix Fast Track Ultra series: 44.1/88.1 kHz 1/Fix playback/capture issues and related chrashes " Felix Homann
2010-09-02  8:33   ` Takashi Iwai
2010-09-02  9:12     ` Clemens Ladisch
2010-09-02  9:16       ` Daniel Mack
2010-09-02 11:13         ` Clemens Ladisch
2010-09-03 13:34           ` Daniel Mack
2010-09-03 14:26             ` Clemens Ladisch
2010-09-02 10:12       ` Felix Homann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C3476BD.4090702@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=fexpop@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.