From: Jiri Slaby <jirislaby@gmail.com>
To: Jarod Wilson <jarod@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-media@vger.kernel.org,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: MEDIA: lirc, improper locking
Date: Wed, 07 Jul 2010 14:52:58 +0200 [thread overview]
Message-ID: <4C3478AA.7070805@gmail.com> (raw)
Hi,
stanse found a locking error in lirc_dev_fop_read:
if (mutex_lock_interruptible(&ir->irctl_lock))
return -ERESTARTSYS;
...
while (written < length && ret == 0) {
if (mutex_lock_interruptible(&ir->irctl_lock)) { #1
ret = -ERESTARTSYS;
break;
}
...
}
remove_wait_queue(&ir->buf->wait_poll, &wait);
set_current_state(TASK_RUNNING);
mutex_unlock(&ir->irctl_lock); #2
If lock at #1 fails, it beaks out of the loop, with the lock unlocked,
but there is another "unlock" at #2.
regards,
--
js
next reply other threads:[~2010-07-07 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 12:52 Jiri Slaby [this message]
2010-07-07 14:00 ` MEDIA: lirc, improper locking Jarod Wilson
2010-07-07 14:29 ` [PATCH] IR/lirc_dev: fix locking in lirc_dev_fop_read Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3478AA.7070805@gmail.com \
--to=jirislaby@gmail.com \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.