Re: [PATCH 2/3]libsepol

["Justin P. Mattock" <justinmattock@gmail.com>]

On 07/07/2010 04:14 AM, Russell Coker wrote:
> On Wed, 7 Jul 2010, "Justin P. Mattock"<justinmattock@gmail.com>  wrote:
>> --- a/libsepol/src/services.c
>> +++ b/libsepol/src/services.c
>> @@ -1050,7 +1049,6 @@ int hidden sepol_load_policy(void *data, size_t len)
>>          /* Install the new policydb and SID table. */
>>          memcpy(policydb,&newpolicydb, sizeof *policydb);
>>          sepol_sidtab_set(sidtab,&newsidtab);
>> -       seqno = ++latest_granting;
>>
>>          /* Free the old policydb and SID table. */
>>          policydb_destroy(&oldpolicydb);
>
> Is latest_granting used for anything else?  If it's not being used then it
> should be removed too.  If it is being used then failing to increment it
> breaks something.
>

doing a grep for all packages shows me this:(no grep in the kernel or 
elsewhere

selinux/libsepol/src/services.c:112:static uint32_t latest_granting = 0;
selinux/libsepol/src/services.c:335:    avd->seqno = latest_granting;
selinux/libsepol/src/services.c:1053:   seqno = ++latest_granting;


Justin P. Mattock


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.