Re: [PATCH] change thread-unsafe readdir to thread-safe readdir_r calls

[Steven Dake <sdake-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On 07/07/2010 11:54 AM, Roland Dreier wrote:
>   >  The readdir POSIX api is not thread safe.  This presents problems in
>   >  multithreaded programs that use the libibverbs APIs.  This patch has been
>   >  tested with a libibverbs application (http://www.corosync.org) on
>   >  Mellanox MT26428 cards.
>
> This is a bit vague.  Is the problem that other threads may do readdir()
> while libibverbs initializes?
>
>   >   #include "ibverbs.h"
>   >
>   >  +
>   >   HIDDEN int abi_ver;
>
> whitespace damage here.
>

thanks I'll fix

>   >  +	buf = (struct dirent *)malloc(offsetof(struct dirent, d_name) + NAME_MAX + 1);
>
> cast of void* is not needed.  Also it seems this could be alloca() and
> simplify things (avoid error checking and freeing).
>

yes..  I can change if you like.  Never been fond of alloca because of 
its limitation on error checking with stack overflow which is unlikely 
in this call path.

Regards
-steve

> Thanks,
>    Roland
>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html