From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [hail patch 1/1] fix hstor crashes Date: Wed, 07 Jul 2010 20:44:57 -0400 Message-ID: <4C351F89.7030208@garzik.org> References: <20100707182157.5fd492fd@lembas.zaitcev.lan> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=OW1KjTnHixTFkzVkq1cft9LBUagKGuqXD0oYO9N9xNM=; b=SHBFxrrZzzsT45aWPf21nDjAmlScfnRv7cOMkXqZ4XKRcb/8lrJ0bax5Uj3O/eVXfX lrHOJHpXF6x6RMpv6sfKgz2b0ZdglFBbUzaEeC+9U3uVGm97Ld0sQpqTLeRezlJnmmZc 5kT1owrcbBGYa33HOji0knPyWpBo5uKFpsKwY= In-Reply-To: <20100707182157.5fd492fd@lembas.zaitcev.lan> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Pete Zaitcev Cc: Project Hail List On 07/07/2010 08:21 PM, Pete Zaitcev wrote: > This patch addresses two bugs: > > - No parameters to search worked (because character '=' was missing, > e.g. delim/ instead of delim=/), and also there were weird truncations > because prefix can easily be longer than 32 characters. > > - If prefix is empty, xmlNodeListGetString returns NULL instead of "", > thus segfault in strdup. This is not easy to accomplish with Boto, > but our own httpstor can do it. > > Signed-off-by: Pete Zaitcev > > --- > lib/hstor.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > This patch was actually tested on httpstor, I've not switched to hstor > yet, but it seems to apply 100%. There's no sense in fixing httpstor, > I'm going to delete it from tabled soon. applied Check out 'libhail-merge' branch of tabled.git, it should have already fixed up the issues and the delete.