From: Patrick Pannuto <ppannuto@codeaurora.org>
To: dbrownell@users.sourceforge.net, gregkh@suse.de,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: sboyd@codeaurora.org
Subject: [PATCH] usb: gadget: #include device.h in gadget.h
Date: Wed, 07 Jul 2010 17:47:08 -0700 [thread overview]
Message-ID: <4C35200C.2040209@codeaurora.org> (raw)
gadget.h uses structures defined in device.h, it must include it. In
most cases, gadget.h is preceded by linux/platform_device.h, but if
you are grouping headers sanely, device.h may not be pulled in until
*after* gadget (e.g. mach/msm_device.h), thus gadget.h should not
rely on something else #including device.h
include/linux/usb/gadget.h:488: error: field 'dev' has incomplete type
include/linux/usb/gadget.h: In function 'set_gadget_data':
include/linux/usb/gadget.h:492:
error: implicit declaration of function 'dev_set_drvdata'
include/linux/usb/gadget.h: In function 'get_gadget_data':
include/linux/usb/gadget.h:494:
error: implicit declaration of function 'dev_get_drvdata'
include/linux/usb/gadget.h:494:
warning: return makes pointer from integer without a cast
include/linux/usb/gadget.h: At top level:
include/linux/usb/gadget.h:780: error: field 'driver' has incomplete type
In file included from include/linux/dmaengine.h:24,
from include/linux/skbuff.h:30,
from include/linux/if_ether.h:124,
from drivers/usb/gadget/u_ether.h:27,
from drivers/usb/gadget/android.c:37:
include/linux/device.h:494: error: conflicting types for 'dev_get_drvdata'
include/linux/usb/gadget.h:494:
note: previous implicit declaration of 'dev_get_drvdata' was here
include/linux/device.h:495:
warning: conflicting types for 'dev_set_drvdata'
include/linux/usb/gadget.h:492:
note: previous implicit declaration of 'dev_set_drvdata' was here
Change-Id: Ia06309b76ac91fc305a1a50fb5e3469cb6adb623
Signed-off-by: Patrick Pannuto <ppannuto@codeaurora.org>
---
include/linux/usb/gadget.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
index bbf45d5..ddca035 100644
--- a/include/linux/usb/gadget.h
+++ b/include/linux/usb/gadget.h
@@ -15,6 +15,8 @@
#ifndef __LINUX_USB_GADGET_H
#define __LINUX_USB_GADGET_H
+#include <linux/device.h>
+
struct usb_ep;
/**
--
1.7.1
next reply other threads:[~2010-07-08 0:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 0:47 Patrick Pannuto [this message]
2010-07-08 3:34 ` [PATCH] usb: gadget: #include device.h in gadget.h Greg KH
2010-07-08 9:03 ` Sergei Shtylyov
2010-07-08 15:13 ` Greg KH
2010-07-08 17:46 ` Sergei Shtylyov
2010-07-08 19:12 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C35200C.2040209@codeaurora.org \
--to=ppannuto@codeaurora.org \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.