All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 3/3] edmini: add IDE support
Date: Thu, 08 Jul 2010 08:11:04 +0200	[thread overview]
Message-ID: <4C356BF8.7030502@free.fr> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19A4A5D169@SC-VEXCH4.marvell.com>

Le 08/07/2010 08:01, Prafulla Wadaskar a ?crit :
>
>
>> -----Original Message-----
>> From: Albert ARIBAUD [mailto:albert.aribaud at free.fr]
>> Sent: Wednesday, July 07, 2010 7:39 PM
>> To: Prafulla Wadaskar
>> Cc: u-boot at lists.denx.de
>> Subject: Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support
>>
>> Le 07/07/2010 13:46, Prafulla Wadaskar a ?crit :
>>
>>>> If you mean 'why not make this a standalone driver, e.g.
>>>> driver/net/mvsata_ide.{ch} under a configuration option
>>>> CONFIG_MVSATA_IDE' -- why not, but it would basically be empty of
>>>> 'driving' functionality (this is handled by cmd_ide) and would only
>>>> provide initialization code, subject to board options (e.g.
>>>> CONFIG_MVSATA_IDE_ENABLE_PORT{0,1}).
>>>
>>> then you should add below initialization code in cpu.c for
>> respective SoCs
>>> and function call here
>>
>> Ok, but that means duplicating this code across SoCs aven
>> though it is
>> actually identical for all of them.
>
> That's why I initially suggested to put it as separate driver than can be used across SoCs.
> Even though it is very small code, it makes more sense creating driver for it.

Ok then, a driver it is.

Amicalement,
-- 
Albert.

  reply	other threads:[~2010-07-08  6:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-06 15:59 [U-Boot] [PATCH V2 1/3] ide: add configuration CONFIG_IDE_SWAP_IO Albert Aribaud
2010-07-06 15:59 ` [U-Boot] [PATCH V2 2/3] orion5x: add ide support for Marvell SATA Albert Aribaud
2010-07-06 15:59   ` [U-Boot] [PATCH V2 3/3] edmini: add IDE support Albert Aribaud
2010-07-07  8:38     ` Prafulla Wadaskar
2010-07-07 10:50       ` Albert ARIBAUD
2010-07-07 11:46         ` Prafulla Wadaskar
2010-07-07 14:08           ` Albert ARIBAUD
2010-07-08  6:01             ` Prafulla Wadaskar
2010-07-08  6:11               ` Albert ARIBAUD [this message]
2010-07-07  8:25   ` [U-Boot] [PATCH V2 2/3] orion5x: add ide support for Marvell SATA Prafulla Wadaskar
2010-07-07 11:23     ` Albert ARIBAUD
2010-07-07 11:37       ` Prafulla Wadaskar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C356BF8.7030502@free.fr \
    --to=albert.aribaud@free.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.