From: Jens Axboe <axboe@kernel.dk>
To: dedekind1@gmail.com
Cc: Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH, RFC] simplify writeback thread creation
Date: Thu, 08 Jul 2010 19:23:36 +0200 [thread overview]
Message-ID: <4C360998.9040609@kernel.dk> (raw)
In-Reply-To: <1278602632.9953.4.camel@localhost>
On 08/07/10 17.23, Artem Bityutskiy wrote:
> On Thu, 2010-07-08 at 16:59 +0200, Jens Axboe wrote:
>>> How about not starting any thread at all at the bdi registration time,
>>> and start a bdi thread only when something for this bdi becomes dirty
>>> (__mark_inode_dirty()) or a bdi work is queued (bdi_queue_work())? If we
>>> do this, then the tasks can also die by the 5min timeout, and will be
>>> forked again when dirt/bdi works arrives?
>>>
>>> I guess it is a bit challenging to start a task in __mark_inode_dirty(),
>>> whis is supposed to be fast and non-sleeping, but we can just submit a
>>> work which will start the task.
>>
>> That work would have to reside on the stack, and __mark_inode_dirty()
>> block on the thread startup. We can't always do that.
>
> We can have a pre-defined bdi->wb->task_start_work or something like
> that.
Yeah, that would work.
--
Jens Axboe
next prev parent reply other threads:[~2010-07-08 17:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 22:52 [PATCH, RFC] simplify writeback thread creation Christoph Hellwig
2010-07-08 7:08 ` Artem Bityutskiy
2010-07-08 12:20 ` Jens Axboe
2010-07-08 14:21 ` Artem Bityutskiy
2010-07-08 14:59 ` Jens Axboe
2010-07-08 15:23 ` Artem Bityutskiy
2010-07-08 17:23 ` Jens Axboe [this message]
2010-07-08 18:43 ` Artem Bityutskiy
2010-07-08 18:48 ` Christoph Hellwig
2010-07-09 7:52 ` Artem Bityutskiy
2010-07-09 8:16 ` Jens Axboe
2010-07-09 11:06 ` Theodore Tso
2010-07-09 14:51 ` Christoph Hellwig
2010-07-09 15:49 ` Artem Bityutskiy
2010-07-08 13:22 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C360998.9040609@kernel.dk \
--to=axboe@kernel.dk \
--cc=dedekind1@gmail.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.