From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] clvmd should create its own pid file
Date: Thu, 08 Jul 2010 20:18:31 +0200 [thread overview]
Message-ID: <4C361677.2030904@redhat.com> (raw)
In-Reply-To: <20100708145916.GT22664@agk-dp.fab.redhat.com>
On 07/08/2010 04:59 PM, Alasdair G Kergon wrote:
> Does this work OK with clvmd -S?
Yes. It appears to be working fine.
> Should we have FD_CLOEXEC ?
>
> (See pidfile.c in multipathd.)
I don't have any special preference. I noticed that the pid file
implementations in other daemons (within lvm2) don't use it nor unlink
the pid file on exit.
> Also, let's make it library code rather than copying it from cmirrord.
Works for me.
I am going to make it a lib call and cleanup both cmirrord/dmeventd/clvmd.
Do you have anything against atexit() handler? That's what we use in
cluster daemons to unlink the pid files.
Cheers
Fabio
next prev parent reply other threads:[~2010-07-08 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 13:04 [PATCH] clvmd should create its own pid file Fabio M. Di Nitto
2010-07-08 14:59 ` Alasdair G Kergon
2010-07-08 18:18 ` Fabio M. Di Nitto [this message]
2010-07-08 18:25 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C361677.2030904@redhat.com \
--to=fdinitto@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.