Re: [PATCH] huawei: recreate the GPRS atom on hup

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

Hi Zhenhua,

On 07/08/2010 05:17 AM, Zhenhua Zhang wrote:
> System is either crashed or usb_serial module reports warnings after
> activate/deactivate GPRS context several times. Handle this by remove
> and recreate the GPRS atom in oFono.
> 
> Tested with Huawei E1552, EM770W.
> System: Ubuntu 9.10.
> Kernel: 2.6.31-16-generic #53-Ubuntu SMP
> ---
>  plugins/huawei.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/plugins/huawei.c b/plugins/huawei.c
> index cfc693d..6cc1448 100644
> --- a/plugins/huawei.c
> +++ b/plugins/huawei.c
> @@ -237,6 +237,7 @@ static void huawei_disconnect(gpointer user_data)
>  	DBG("");
>  
>  	ofono_gprs_context_remove(data->gc);
> +	ofono_gprs_remove(data->gprs);
>  
>  	g_at_chat_unref(data->modem);
>  	data->modem = NULL;
> @@ -250,6 +251,7 @@ static void huawei_disconnect(gpointer user_data)
>  
>  	ofono_info("Reopened GPRS context channel");
>  
> +	data->gprs = ofono_gprs_create(modem, 0, "atmodem", data->pcui);
>  	data->gc = ofono_gprs_context_create(modem, 0, "atmodem",
>  							data->modem);
>  

This is really not the preferred solution.  Can we investigate deeper
into what is crashing here?  Perhaps we're not waiting on the 'NO
CARRIER' signal from the modem before attempting another context activation?

Regards,
-Denis