From: A Large Angry SCM <gitzilla@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Eric Wong <normalperson@yhbt.net>,
Torsten Schmutzler <git-ts@theblacksun.eu>
Subject: Re: [PATCH] t9118: avoid PEG revision identifier in tests
Date: Thu, 08 Jul 2010 15:33:27 -0400 [thread overview]
Message-ID: <4C362807.80703@gmail.com> (raw)
In-Reply-To: <2f9f1bd8efb818456fcc386f419fc17f4e435e19.1278616418.git.git@drmicha.warpmail.net>
On 07/08/2010 03:16 PM, Michael J Gruber wrote:
> @ is SVN's identifier for PEG revisions. But SVN's treatment of PEG
> identifiers in copy target URLs changed in r954995/r952973, i.e. between
> 1.6.11 and 1.6.12. They get eaten now (which is considered the right
> way).
>
> Therefore, avoid the @ in the tests with funky branch names.
>
> Signed-off-by: Michael J Gruber<git@drmicha.warpmail.net>
> ---
> This version is tested with svn 1.6.9 and 1.6.12.
>
> t/t9118-git-svn-funky-branch-names.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/t/t9118-git-svn-funky-branch-names.sh b/t/t9118-git-svn-funky-branch-names.sh
> index 7d7acc3..45d5b2d 100755
> --- a/t/t9118-git-svn-funky-branch-names.sh
> +++ b/t/t9118-git-svn-funky-branch-names.sh
> @@ -28,7 +28,7 @@ test_expect_success 'setup svnrepo' '
> svn_cmd cp -m "trailing .lock" "$svnrepo/pr ject/trunk" \
> "$svnrepo/pr ject/branches/trailing_dotlock.lock"&&
> svn_cmd cp -m "reflog" "$svnrepo/pr ject/trunk" \
> - "$svnrepo/pr ject/branches/not-a@{0}reflog"&&
> + "$svnrepo/pr ject/branches/not-a%40{0}reflog"&&
> start_httpd
> '
>
With this patch, 'make test' now passes, and make -j4 test' does also.
next prev parent reply other threads:[~2010-07-08 19:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 20:20 [PATCH] git-svn: mangle refnames forbidden in git Torsten Schmutzler
2010-05-09 8:35 ` Eric Wong
2010-07-08 8:43 ` Jonathan Nieder
2010-07-08 8:58 ` Eric Wong
2010-07-08 13:03 ` Jonathan Nieder
2010-07-08 18:53 ` Michael J Gruber
2010-07-08 19:16 ` [PATCH] t9118: avoid PEG revision identifier in tests Michael J Gruber
2010-07-08 19:33 ` A Large Angry SCM [this message]
2010-07-08 20:38 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C362807.80703@gmail.com \
--to=gitzilla@gmail.com \
--cc=git-ts@theblacksun.eu \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.