All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Miller <davem@davemloft.net>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 03/23] lmb: Print new doubled array location info
Date: Thu, 08 Jul 2010 13:07:38 -0700	[thread overview]
Message-ID: <4C36300A.7030606@kernel.org> (raw)
In-Reply-To: <201007081255.58049.bjorn.helgaas@hp.com>

On 07/08/2010 11:55 AM, Bjorn Helgaas wrote:
> On Sunday, July 04, 2010 12:56:07 am Yinghai Lu wrote:
>> -		pr_info(" %s[0x%x]\t0x%016llx - 0x%016llx, 0x%llx bytes\n",
>> -		    name, i, base, base + size - 1, size);
>> +		pr_info(" %s[%#x]\t[%#016llx - %#016llx], %#llx bytes\n",
>> +		    name, i, base, base + size, size);
> 
> I know you think it's prettier to have zeroes and extra spaces like this:
> 
>   [0xe7000000 - 0xe8000000, 0x1000000 bytes]
> 
> rather than a bunch of 'F's:
> 
>   [0xe7000000-0xe7ffffff]
> 
> But for the record, I still think you're wrong and that it's better
> to be consistent even if it's slightly uglier.  The inconsistencies
> lead to confusion and off-by-one errors.

We can make them to be consistent later.

current for early mem stage, it is consistent to without -1.

later I like to see all pci resource could be consistent to without -1 too.

Thanks

Yinghai

  reply	other threads:[~2010-07-08 20:12 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-04  6:56 [PATCH -v22 00/23] Use lmb with x86 Yinghai Lu
2010-07-04  6:56 ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 01/23] lmb: lmb_find_base() should return LMB_ERROR on failing path Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 02/23] lmb: Prepare x86 to use lmb to replace early_res Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 03/23] lmb: Print new doubled array location info Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-08 18:55   ` Bjorn Helgaas
2010-07-08 20:07     ` Yinghai Lu [this message]
2010-07-09  6:19       ` Benjamin Herrenschmidt
2010-07-04  6:56 ` [PATCH 04/23] lmb: Export LMB_ERROR again Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 05/23] lmb: Prepare to include linux/lmb.h in core file Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 06/23] lmb: Add ARCH_DISCARD_LMB to put lmb code to .init Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 07/23] lmb: Add lmb_find_in_range() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 08/23] x86, lmb: Add lmb_x86_find_in_range_size() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 09/23] bootmem, x86: Add weak version of reserve_bootmem_generic Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 10/23] x86, lmb: Add lmb_x86_to_bootmem() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 11/23] x86,lmb: Add lmb_x86_reserve_range/lmb_x86_free_range Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 12/23] x86, lmb: Add get_free_all_memory_range() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 13/23] x86, lmb: Add lmb_x86_register_active_regions() and lmb_x86_hole_size() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 14/23] lmb: Add find_memory_core_early() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 15/23] x86, lmb: Add lmb_x86_find_in_range_node() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 16/23] x86, lmb: Add lmb_x86_free_memory_in_range() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 17/23] x86, lmb: Add lmb_x86_memory_in_range() Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 18/23] x86, lmb: Use lmb_debug to control debug message print out Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 19/23] x86: Use lmb to replace early_res Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 20/23] x86: Replace e820_/_early string with lmb_ Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 21/23] x86: Remove not used early_res code Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 22/23] x86, lmb: Use lmb_memory_size()/lmb_free_memory_size() to get correct dma_reserve Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu
2010-07-04  6:56 ` [PATCH 23/23] x86: remove old bootmem code Yinghai Lu
2010-07-04  6:56   ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C36300A.7030606@kernel.org \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=davem@davemloft.net \
    --cc=hannes@cmpxchg.org \
    --cc=hpa@zytor.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.