From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Add init phonesim stk support
Date: Thu, 08 Jul 2010 15:10:44 -0500 [thread overview]
Message-ID: <4C3630C4.1090409@gmail.com> (raw)
In-Reply-To: <1278586608-6246-1-git-send-email-yang.gu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
Hi Yang,
On 07/08/2010 05:56 AM, Yang Gu wrote:
> ---
> Makefile.am | 28 ++--
> drivers/phonesimmodem/phonesimmodem.c | 48 +++++
> drivers/phonesimmodem/phonesimmodem.h | 26 +++
> drivers/phonesimmodem/stk.c | 316 +++++++++++++++++++++++++++++++++
> plugins/phonesim.c | 2 +-
Another thought just occurred here, instead of duplicating all this work
inside phonesimmodem, lets just have a separate function inside
sim-poll.c that will listen to the phonesim specific notification. E.g.
instead of atmodem_poll_enable have something like phonesim_poll_enable.
Regards,
-Denis
prev parent reply other threads:[~2010-07-08 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 10:56 [PATCH] Add init phonesim stk support Yang Gu
2010-07-08 19:52 ` Denis Kenzior
2010-07-08 20:10 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3630C4.1090409@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.