All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] pid files cleanup
Date: Fri, 09 Jul 2010 11:04:04 +0200	[thread overview]
Message-ID: <4C36E604.6090106@redhat.com> (raw)

Hi all,

as previously discussed, the patch:

- adds a generic create_lockfile fn to lvm-file.{c,h}. Based on
multipathd/pidfile.c
- adds --clvmd-pidfile configure option (autoreconf on F-12)
- make clvmd use the new create_lockfile
- make cmirrord use the new create_lockfile and drop duplicate code
- unlink pidfiles on exit (note that because of the atexit() behavior
this has to be done locally in the daemon and cannot be generalized in
the library).

NOTES:

- I had some issues to build dmeventd that I need to investigate
locally. dmeventd also needs to be ported (if possible) to use the
library implementation of create_lockfile().

- create_lockfile can probably use fcntl_lock_file, but I am not
entirely sure about its behavior yet (specially the waiting note in the
header), so I choose a safe path for now and use a known (to me)
implementation.

- WHATS_NEW will be updated once patch is ACK.

Thanks
Fabio
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pid_files.diff
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20100709/b8252385/attachment.ksh>

             reply	other threads:[~2010-07-09  9:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-09  9:04 Fabio M. Di Nitto [this message]
2010-07-09 13:09 ` [PATCH] pid files cleanup Alasdair G Kergon
2010-07-09 13:18   ` Fabio M. Di Nitto
2010-07-09 13:11 ` Alasdair G Kergon
2010-07-09 13:20   ` Fabio M. Di Nitto
2010-07-09 13:28     ` Alasdair G Kergon
2010-07-09 13:20 ` Alasdair G Kergon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C36E604.6090106@redhat.com \
    --to=fdinitto@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.