Re: [PATCH 06/11] USB: s3c-hsotg: Only load packet per fifo write

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

Ben Dooks wrote:

> Limit the IN FIFO write to a single packet per attempt at writing,
> as per the specifications and ensure that we don't return fifo-full
> so that we can continue writing packets if we have the space.

> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
[...]
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 4196e37..df6a39d 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -538,6 +538,17 @@ static int s3c_hsotg_write_fifo(struct s3c_hsotg *hsotg,
>  	if (can_write > 512)
>  		can_write = 512;
>  
> +	/* limit the write to one max-packet size worth of data, but allow
> +	 * the transfer to return that it did not run out of fifo space
> +	 * doing it. */

   According to CodingStyle, the preferred style for the multi-line commnets 
is this:

/*
  * bla
  * bla
  */

WBR, Sergei