From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/3] Interpret "" Alpha Id as empty data object
Date: Fri, 09 Jul 2010 12:32:01 -0500 [thread overview]
Message-ID: <4C375D11.8060802@gmail.com> (raw)
In-Reply-To: <1278687128-8983-3-git-send-email-yang.gu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
On 07/09/2010 09:52 AM, Yang Gu wrote:
> There needs to be a way to distinguish between no alphaid and "empty
> data object" because on some occasions they have different meanings. In
> the Call Control envelope, no Alpha Identifier means the terminal can
> inform the user about the call being modified by SIM while empty data
> object means no hint should be given.
I applied this one, however I noticed that lots of unit tests for things
besides call control were affected. Question to both of you: Should we
g_free & NULL empty Alpha Identifiers in commands that do not allow this
to be empty?
Regards,
-Denis
next prev parent reply other threads:[~2010-07-09 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 14:52 [PATCH 1/3] Make fetch command function as external Yang Gu
2010-07-09 14:52 ` [PATCH 2/3] Support phonesim proactive command notification Yang Gu
2010-07-09 17:18 ` Denis Kenzior
2010-07-09 14:52 ` [PATCH 3/3] Interpret "" Alpha Id as empty data object Yang Gu
2010-07-09 15:22 ` Gu, Yang
2010-07-09 17:32 ` Denis Kenzior [this message]
2010-07-11 13:59 ` Gu, Yang
2010-07-09 15:09 ` [PATCH 1/3] Make fetch command function as external Gu, Yang
2010-07-09 17:17 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C375D11.8060802@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.