From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailrelay3.sunrise.ch ([194.158.229.31] helo=smtp-be-01.be08.sunrise.ch) by linuxtogo.org with esmtp (Exim 4.69) (envelope-from ) id 1OYGLg-0008AQ-Rj for openembedded-devel@lists.openembedded.org; Mon, 12 Jul 2010 12:34:57 +0200 Received: from [192.168.26.14] (212-98-43-140.static.adslpremium.ch [212.98.43.140]) by smtp-be-01.be08.sunrise.ch (8.13.1/8.12.10) with ESMTP id o6CATtNv021588; Mon, 12 Jul 2010 12:29:55 +0200 Message-ID: <4C3AEED8.5080907@vollmann.ch> Date: Mon, 12 Jul 2010 12:30:48 +0200 From: Detlef Vollmann User-Agent: Thunderbird 2.0.0.24 (X11/20100317) MIME-Version: 1.0 To: openembedded-devel@lists.openembedded.org X-SA-Exim-Connect-IP: 194.158.229.31 X-SA-Exim-Mail-From: dv@vollmann.ch X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on discovery X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:20:07 +0000) X-SA-Exim-Scanned: Yes (on linuxtogo.org) Subject: Patches from VCS X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jul 2010 10:34:57 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit patch.bbclass contains this line (62): url = bb.encodeurl((type, host, path, user, pswd, [])) This line removes the parms from url bevore giving it to the fetcher to compute the localpath. This effectivly disallows getting the patch from a version control system (given that supports fetching single files). So I'm curious about the reason for the above line. The fetcher has to cope with all parms anyway in do_fetch, so the only reason I can see is either (false) optimization or to explicitely forbid fetching patches from a VCS. Has anyone a problem with removing that line? Detlef