From: "H. Peter Anvin" <hpa@zytor.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Yinghai Lu <yinghai.lu@oracle.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Setup early console as early as possible
Date: Mon, 12 Jul 2010 08:47:03 -0700 [thread overview]
Message-ID: <4C3B38F7.1050400@zytor.com> (raw)
In-Reply-To: <4C3AD94C.7070807@cs.helsinki.fi>
On 07/12/2010 01:58 AM, Pekka Enberg wrote:
> Hi Yinghai,
>
> Yinghai Lu wrote:
>> Analyze "console=uart8250,io,0x3f8,115200n8" in
>> i386_start_kernel/x86_64_start_kernel,
>> and call setup_early_serial8250_console() to init early serial console.
>>
>> only can handle io port kind of 8250. because mmio need ioremap.
>>
>> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> What's the purpose of this patch? Does it make my early boot I/O patch
> obsolete?
>
> Pekka
No, they're complementary. Your patch serial-port enables the RM
kernel, whereas Yinghai pushes the initialization earlier in the PM kernel.
Incidentally, Yinghai: it would be possible to push even an MMIO
reference earlier by reserving a fixmap slot for the early console. I'm
not sure if it's worth it, though.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-07-12 15:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-11 21:44 [PATCH] x86: Setup early console as early as possible Yinghai Lu
2010-07-12 8:58 ` Pekka Enberg
2010-07-12 15:47 ` H. Peter Anvin [this message]
2010-07-12 16:21 ` Yinghai Lu
2010-07-12 17:30 ` H. Peter Anvin
2010-07-13 17:43 ` Pekka Enberg
2010-07-13 20:35 ` Yinghai Lu
2010-07-13 20:46 ` Pekka Enberg
2010-07-14 2:07 ` [PATCH] x86: only set early_serial_base after port is initialized Yinghai Lu
2010-07-14 8:41 ` Pekka Enberg
2010-07-14 18:26 ` [PATCH -v2] x86: only set early_serial_base after port is initialized in setup code Yinghai Lu
2010-07-14 19:12 ` [tip:x86/setup] x86, setup: Only set early_serial_base after port is initialized tip-bot for Yinghai Lu
2010-07-13 21:12 ` [tip:x86/setup] x86, setup: Make the setup code also accept console=uart8250 tip-bot for Yinghai Lu
2010-07-12 17:44 ` [PATCH] x86: Setup early console as early as possible Cyrill Gorcunov
2010-07-12 18:09 ` H. Peter Anvin
2010-07-12 18:11 ` Yinghai Lu
2010-07-12 22:57 ` Jeremy Fitzhardinge
2010-07-12 23:37 ` Yinghai Lu
[not found] <f5czp-42V-9@gated-at.bofh.it>
[not found] ` <f5n1M-2lt-21@gated-at.bofh.it>
[not found] ` <f5tqz-3ll-37@gated-at.bofh.it>
[not found] ` <f5u3g-4mj-11@gated-at.bofh.it>
[not found] ` <f5v90-5Wo-7@gated-at.bofh.it>
2010-07-12 20:57 ` Bodo Eggert
2010-07-12 21:52 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3B38F7.1050400@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=tglx@linutronix.de \
--cc=yinghai.lu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.