All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Andy Whitcroft <apw@canonical.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Possible false positive from checkpatch.pl
Date: Mon, 12 Jul 2010 12:52:32 -0500	[thread overview]
Message-ID: <4C3B5660.8020405@lwfinger.net> (raw)

Andy,

In preparing a vendor driver for submission to staging, I am getting the 
following from checkpatch.pl:

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#377: FILE: staging/rtl8712/rtl871x_mp_ioctl.h:377:
+#define GEN_MP_IOCTL_HANDLER(sz, hdl, oid) {sz, hdl, oid},

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#378: FILE: staging/rtl8712/rtl871x_mp_ioctl.h:378:
+#define EXT_MP_IOCTL_HANDLER(sz, subcode, oid) {sz, &mp_ioctl_ \
+       ## subcode ## _hdl, oid},

total: 2 errors, 0 warnings, 466 lines checked

Enclosing these macros in a do {...} while (0) is definitely wrong and will not 
compile. Moving the comma from the end of the macro to the lines that invoke it 
fixes the problem, but should not be necessary.

Thanks,


             reply	other threads:[~2010-07-12 17:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-12 17:52 Larry Finger [this message]
2010-07-12 18:28 ` Possible false positive from checkpatch.pl Joe Perches
2010-07-12 18:35   ` Larry Finger
2010-07-12 19:03     ` Joe Perches
2010-07-12 19:37       ` Larry Finger
2010-07-12 19:49         ` Joe Perches
2010-07-14 13:14           ` Andy Whitcroft
2010-07-14 16:16             ` Joe Perches
2010-07-14 13:13 ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C3B5660.8020405@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.