Re: [PATCH] uvc: Fix multiple symbols definitions with UVC gadget and host drivers

[Randy Dunlap <randy.dunlap@oracle.com>]

Laurent Pinchart wrote:
> The UVC gadget driver borrowed code from the UVC host driver without
> changing the symbol names. This results in a namespace clash with
> multiple definitions of several symbols when compiling both drivers in
> the kernel.
> 
> Make all generic UVC functions and variables static in the UVC gadget
> driver, as the symbols are not referenced outside of the gadget driver.
> Rename the uvc_trace_param global variable to uvc_gadget_trace_param.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks.

> ---
>  drivers/usb/gadget/f_uvc.c     |    4 +-
>  drivers/usb/gadget/uvc.h       |   10 +--
>  drivers/usb/gadget/uvc_queue.c |  153 +++++++++++++++++++++-------------------
>  drivers/usb/gadget/uvc_queue.h |   20 -----
>  drivers/usb/gadget/uvc_v4l2.c  |    2 +-
>  drivers/usb/gadget/uvc_video.c |    6 +-
>  drivers/usb/gadget/webcam.c    |    4 +-
>  7 files changed, 89 insertions(+), 110 deletions(-)