[Qemu-devel] Re: [PATCH 0/8] vlan cleanup

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 2655 bytes --]

Miguel Di Ciurcio Filho wrote:
> This series removes the vlan stuff without mercy. I've tried to make the steps
> as small as possible, but the last one is huge. I did some basic tests and
> networking is still working, so reviews are welcome :-D

Sorry, this is a bit too rude. This not only removes the vlan model,
something one may talk about, but also the innocent socket back-ends and
the useful pcap dump support.

Socket back-ends allow quick and easy unprivileged inter-VM network
setups. Nothing for production systems, but useful for testing purposes
on boxes where taps are not allowed or unhandy to configure.

The dump client helps to debug user mode guest networks, namely slirp
which you did not remove. If that should become the only use case for
vlans with more than 2 nodes, we could think about making it a special
feature of backend devices.

I'm open for cleanups here, but they do require a bit mercy - and should
also mention the reason.

Jan

> 
> A next step would be to rename VLANClientState and other structures to more
> proper names.
> 
> Regards,
> 
> Miguel
> 
> ---
> 
> Miguel Di Ciurcio Filho (8):
>       vlan cleanup: update documentation
>       vlan cleanup: update options
>       vlan cleanup: do not depend on socket and dump
>       vlan cleanup: do not build socket and dump
>       vlan cleanup: remove socket.h and socket.c
>       vlan cleanup: remove dump.h and dump.c
>       vlan cleanup: remove legacy monitor commands
>       vlan cleanup: remove usage of VLANState
> 
>  Makefile.objs        |    2 -
>  hw/qdev-properties.c |   39 ----
>  hw/qdev.c            |    2 -
>  hw/qdev.h            |    5 -
>  hw/xen_devconfig.c   |    8 +-
>  hw/xen_nic.c         |    1 -
>  net.c                |  425 +++----------------------------------
>  net.h                |   12 -
>  net/dump.c           |  159 --------------
>  net/dump.h           |   33 ---
>  net/slirp.c          |   54 ++----
>  net/slirp.h          |    3 +-
>  net/socket.c         |  573 --------------------------------------------------
>  net/socket.h         |   33 ---
>  net/tap.c            |    9 +-
>  net/tap.h            |    2 +-
>  net/vde.c            |    8 +-
>  net/vde.h            |    2 +-
>  qemu-common.h        |    1 -
>  qemu-doc.texi        |   24 +--
>  qemu-monitor.hx      |   36 +---
>  qemu-options.hx      |  120 ++---------
>  22 files changed, 89 insertions(+), 1462 deletions(-)
>  delete mode 100644 net/dump.c
>  delete mode 100644 net/dump.h
>  delete mode 100644 net/socket.c
>  delete mode 100644 net/socket.h
> 
> 
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]