From: Mike Christie <michaelc@cs.wisc.edu>
To: Jayamohan Kalickal <jayamohank@serverengines.com>
Cc: linux-scsi@vger.kernel.org, James.Bottomley@suse.de
Subject: Re: [PATCH 03/20] be2iscsi: Fixing the return type of functions
Date: Tue, 13 Jul 2010 02:33:03 -0500 [thread overview]
Message-ID: <4C3C16AF.8090204@cs.wisc.edu> (raw)
In-Reply-To: <4C3C15C9.1030509@cs.wisc.edu>
On 07/13/2010 02:29 AM, Mike Christie wrote:
> On 07/12/2010 12:50 PM, Jayamohan Kallickal wrote:
>> -
>> -unsigned char mgmt_epfw_cleanup(struct beiscsi_hba *phba, unsigned
>> short chute)
>> +int mgmt_epfw_cleanup(struct beiscsi_hba *phba, unsigned short chute)
>> {
>> struct be_ctrl_info *ctrl =&phba->ctrl;
>> struct be_mcc_wrb *wrb = wrb_from_mccq(phba);
>> @@ -144,7 +143,7 @@ unsigned char mgmt_epfw_cleanup(struct beiscsi_hba
>> *phba, unsigned short chute)
>> return status;
>> }
>>
>
> You forgot to change the caller of this function.
Nevermind. I see you fixed it up in a later patch. Next time, just
include both in the one patch since they go together.
prev parent reply other threads:[~2010-07-13 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 17:50 [PATCH 03/20] be2iscsi: Fixing the return type of functions Jayamohan Kallickal
2010-07-13 7:29 ` Mike Christie
2010-07-13 7:33 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3C16AF.8090204@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@suse.de \
--cc=jayamohank@serverengines.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.