From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Christie Subject: Re: [PATCH 03/20] be2iscsi: Fixing the return type of functions Date: Tue, 13 Jul 2010 02:33:03 -0500 Message-ID: <4C3C16AF.8090204@cs.wisc.edu> References: <20100712175006.GA11396@serverengines.com> <4C3C15C9.1030509@cs.wisc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from sabe.cs.wisc.edu ([128.105.6.20]:47790 "EHLO sabe.cs.wisc.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494Ab0GMH3t (ORCPT ); Tue, 13 Jul 2010 03:29:49 -0400 In-Reply-To: <4C3C15C9.1030509@cs.wisc.edu> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Jayamohan Kalickal Cc: linux-scsi@vger.kernel.org, James.Bottomley@suse.de On 07/13/2010 02:29 AM, Mike Christie wrote: > On 07/12/2010 12:50 PM, Jayamohan Kallickal wrote: >> - >> -unsigned char mgmt_epfw_cleanup(struct beiscsi_hba *phba, unsigned >> short chute) >> +int mgmt_epfw_cleanup(struct beiscsi_hba *phba, unsigned short chute) >> { >> struct be_ctrl_info *ctrl =&phba->ctrl; >> struct be_mcc_wrb *wrb = wrb_from_mccq(phba); >> @@ -144,7 +143,7 @@ unsigned char mgmt_epfw_cleanup(struct beiscsi_hba >> *phba, unsigned short chute) >> return status; >> } >> > > You forgot to change the caller of this function. Nevermind. I see you fixed it up in a later patch. Next time, just include both in the one patch since they go together.