From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OYc6I-0002fH-RP for mharc-grub-devel@gnu.org; Tue, 13 Jul 2010 05:48:30 -0400 Received: from [140.186.70.92] (port=46059 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYc69-0002av-Pp for grub-devel@gnu.org; Tue, 13 Jul 2010 05:48:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYc68-0005at-3Y for grub-devel@gnu.org; Tue, 13 Jul 2010 05:48:21 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:44338) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYc67-0005ai-TB for grub-devel@gnu.org; Tue, 13 Jul 2010 05:48:20 -0400 Received: by bwz9 with SMTP id 9so3786366bwz.0 for ; Tue, 13 Jul 2010 02:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=Xvx2FPXFvwypYaDUMU2ePG4rlneDHiO8MWmpxk5kXMQ=; b=WCzB1bCVPSOmUtO9chuz9KWQKCH+dKs72pN1nlELEWcJWy6TncrJF71Jhlcwj56arW 3fyo/XJnXHJMlDF3T/O98XSnMoUf69lf45X/ddd+aF6aIDmDEncA2Z7ZzsBjMmI/5gqD mAHma57xZd9fdWeAkTHF8Ql8vhkLOoq2wvkzk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=MYosXUGdcEdgIbgUQhCc5zLLpX2Uj0yg/fl2JkoUV6t/X3h+YcrmZ7c6U9NhpFsviw gN4+kwSeZ5BcE+LAOhGrCI799l+leShTkOjMflik6LW0Okymxib9f4BoG9zwIj2Tf6Yv U50dstZsIBogXltq+idYOdUZbkZ+vhYDKbD7M= Received: by 10.204.24.1 with SMTP id t1mr11550638bkb.178.1279014498771; Tue, 13 Jul 2010 02:48:18 -0700 (PDT) Received: from debian.bg45.phnet (vpn-global-158-dhcp.ethz.ch [129.132.211.158]) by mx.google.com with ESMTPS id a9sm17416940bky.11.2010.07.13.02.48.16 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 13 Jul 2010 02:48:17 -0700 (PDT) Message-ID: <4C3C365F.2030006@gmail.com> Date: Tue, 13 Jul 2010 11:48:15 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100620 Icedove/3.0.5 MIME-Version: 1.0 To: grub-devel@gnu.org References: <87pqyzwmf5.wl%jir@sekiba.com> <4C3BA145.8020002@gmail.com> <871vb816bt.wl%jir@sekiba.com> In-Reply-To: <871vb816bt.wl%jir@sekiba.com> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig7CB2C97982C90CB80B4CFE27" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] fix calculation of 2nd superblock position. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2010 09:48:28 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7CB2C97982C90CB80B4CFE27 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/13/2010 04:08 AM, Jiro SEKIBA wrote: > At Tue, 13 Jul 2010 01:12:05 +0200, > Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: > =20 >> [1 ] >> [1.1 ] >> On 07/07/2010 01:39 PM, Jiro SEKIBA wrote: >> =20 >>> Hi, >>> >>> This patch fixes calculation of 2nd superblock position. >>> >>> nilfs2 has two super blocks, the 1st one is at beginning of the parti= tion, >>> the 2nd one is the end of partition. 2nd one resides at last 4k bloc= k. >>> However when the partition size is not a multiple of 4k bytes, the >>> remainder will be ignored. >>> >>> 2010-07-07 Jiro SEKIBA >>> >>> * fs/nilfs2.c: fix macro NILFS_2ND_SUPER_BLOCK to calculate >>> 2nd superblock position from partition size. >>> >>> =20 >>> =20 >> Go ahead for trunk >> =20 > Sorry, but what am I supposed to do? > Did I have a write access to the trunk? > > =20 No, I plainly forgot to give you one. What's your savannah account? I committed your patch. >>> =3D=3D=3D modified file 'fs/nilfs2.c' >>> --- fs/nilfs2.c 2010-05-31 18:49:42 +0000 >>> +++ fs/nilfs2.c 2010-07-07 10:58:13 +0000 >>> @@ -52,9 +52,9 @@ >>> /* nilfs 1st super block posission from beginning of the partition >>> in 512 block size */ >>> #define NILFS_1ST_SUPER_BLOCK 2 >>> -/* nilfs 2nd super block posission from end of the partition >>> +/* nilfs 2nd super block posission from beginning of the partition >>> in 512 block size */ >>> -#define NILFS_2ND_SUPER_BLOCK 8 >>> +#define NILFS_2ND_SUPER_BLOCK(devsize) (((devsize >> 3) - 1) << 3) >>> =20 >>> struct grub_nilfs2_inode >>> { >>> @@ -729,7 +729,7 @@ >>> if (partition_size !=3D GRUB_DISK_SIZE_UNKNOWN) >>> { >>> /* Read second super block. */ >>> - grub_disk_read (disk, partition_size - NILFS_2ND_SUPER_BLOCK, = 0, >>> + grub_disk_read (disk, NILFS_2ND_SUPER_BLOCK (partition_size), = 0, >>> sizeof (struct grub_nilfs2_super_block), &sb2); >>> /* Make sure if 2nd super block is valid. */ >>> valid[1] =3D grub_nilfs2_valid_sb (&sb2); >>> >>> >>> =20 >>> =20 >> >> --=20 >> Regards >> Vladimir '=CF=86-coder/phcoder' Serbinenko >> >> >> [1.2 OpenPGP digital signature ] >> >> [2 ] >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> http://lists.gnu.org/mailman/listinfo/grub-devel >> =20 > > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig7CB2C97982C90CB80B4CFE27 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkw8Nl8ACgkQNak7dOguQgkzXQD/YdWn4llnUW6GbJEuOuqbtVlQ zQRsEmfR5Xc8YkZ/HA4A/A8Z45qprhjhNiJJVxWEtD5zsKnUyj0sMOmeIXM15Mb/ =8SGM -----END PGP SIGNATURE----- --------------enig7CB2C97982C90CB80B4CFE27--