diff for duplicates of <4C3C7803.2020006@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 4df73cf..acb1abc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -33,7 +33,7 @@ > +++ b/fs/ext2/xattr.c > @@ -161,6 +161,13 @@ ext2_xattr_get(struct inode *inode, int name_index, const char *name, > -> if (name = NULL) +> if (name == NULL) > return -EINVAL; > + > + /* find named attribute */ @@ -57,7 +57,8 @@ > - goto cleanup; > entry = FIRST_ENTRY(bh); > while (!IS_LAST_ENTRY(entry)) { -> struct ext2_xattr_entry *next Hi, I noticed in ext2_xattr_set, name_len check is done +> struct ext2_xattr_entry *next = +Hi, I noticed in ext2_xattr_set, name_len check is done before down_write(&EXT2_I(inode)->xattr_sem); So I think ext2_xattr_get should do in the same way. diff --git a/a/content_digest b/N1/content_digest index 1f056b0..cf5b909 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0201007122229025316610@gmail.com\0" "From\0Wang Sheng-Hui <crosslonelyover@gmail.com>\0" - "Subject\0Re: [PATCH] check name_len before down_read xattr_sem and sb_read\0" - "Date\0Tue, 13 Jul 2010 14:28:19 +0000\0" + "Subject\0Re: [PATCH] check name_len before down_read xattr_sem and sb_read in ext2_xattr_get\0" + "Date\0Tue, 13 Jul 2010 22:28:19 +0800\0" "To\0linux-ext4 <linux-ext4@vger.kernel.org>" linux-kernel <linux-kernel@vger.kernel.org> kernel-janitors <kernel-janitors@vger.kernel.org> @@ -45,7 +45,7 @@ "> +++ b/fs/ext2/xattr.c\n" "> @@ -161,6 +161,13 @@ ext2_xattr_get(struct inode *inode, int name_index, const char *name,\n" ">\n" - "> \tif (name = NULL)\n" + "> \tif (name == NULL)\n" "> \t\treturn -EINVAL;\n" "> +\n" "> +\t/* find named attribute */\n" @@ -69,7 +69,8 @@ "> -\t\tgoto cleanup;\n" "> \tentry = FIRST_ENTRY(bh);\n" "> \twhile (!IS_LAST_ENTRY(entry)) {\n" - "> \t\tstruct ext2_xattr_entry *next Hi, I noticed in ext2_xattr_set, name_len check is done\n" + "> \t\tstruct ext2_xattr_entry *next =\n" + "Hi, I noticed in ext2_xattr_set, name_len check is done\n" "before\n" "down_write(&EXT2_I(inode)->xattr_sem);\n" "So I think ext2_xattr_get should do in the same way.\n" @@ -80,4 +81,4 @@ "Thanks and Regards,\n" shenghui -f05093b425e4126e14a8b0217c22f698835d5fa9a312aecd04247cfb9d4b7f42 +2b2e32abdf96bfdcc249feff67fbf6568aebb0c11763b92ef753adf93e5dd9f8
diff --git a/a/1.txt b/N2/1.txt index 4df73cf..acb1abc 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -33,7 +33,7 @@ > +++ b/fs/ext2/xattr.c > @@ -161,6 +161,13 @@ ext2_xattr_get(struct inode *inode, int name_index, const char *name, > -> if (name = NULL) +> if (name == NULL) > return -EINVAL; > + > + /* find named attribute */ @@ -57,7 +57,8 @@ > - goto cleanup; > entry = FIRST_ENTRY(bh); > while (!IS_LAST_ENTRY(entry)) { -> struct ext2_xattr_entry *next Hi, I noticed in ext2_xattr_set, name_len check is done +> struct ext2_xattr_entry *next = +Hi, I noticed in ext2_xattr_set, name_len check is done before down_write(&EXT2_I(inode)->xattr_sem); So I think ext2_xattr_get should do in the same way. diff --git a/a/content_digest b/N2/content_digest index 1f056b0..445c86e 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,13 +1,13 @@ "ref\0201007122229025316610@gmail.com\0" "From\0Wang Sheng-Hui <crosslonelyover@gmail.com>\0" - "Subject\0Re: [PATCH] check name_len before down_read xattr_sem and sb_read\0" - "Date\0Tue, 13 Jul 2010 14:28:19 +0000\0" + "Subject\0Re: [PATCH] check name_len before down_read xattr_sem and sb_read in ext2_xattr_get\0" + "Date\0Tue, 13 Jul 2010 22:28:19 +0800\0" "To\0linux-ext4 <linux-ext4@vger.kernel.org>" linux-kernel <linux-kernel@vger.kernel.org> kernel-janitors <kernel-janitors@vger.kernel.org> tytso@mit.edu adilger@sun.com - " akpm@linux-fou\0" + " akpm@linux-foundation.org\0" "\00:1\0" "b\0" " \344\272\216 2010-7-12 22:29, crosslonelyover \345\206\231\351\201\223:\n" @@ -45,7 +45,7 @@ "> +++ b/fs/ext2/xattr.c\n" "> @@ -161,6 +161,13 @@ ext2_xattr_get(struct inode *inode, int name_index, const char *name,\n" ">\n" - "> \tif (name = NULL)\n" + "> \tif (name == NULL)\n" "> \t\treturn -EINVAL;\n" "> +\n" "> +\t/* find named attribute */\n" @@ -69,7 +69,8 @@ "> -\t\tgoto cleanup;\n" "> \tentry = FIRST_ENTRY(bh);\n" "> \twhile (!IS_LAST_ENTRY(entry)) {\n" - "> \t\tstruct ext2_xattr_entry *next Hi, I noticed in ext2_xattr_set, name_len check is done\n" + "> \t\tstruct ext2_xattr_entry *next =\n" + "Hi, I noticed in ext2_xattr_set, name_len check is done\n" "before\n" "down_write(&EXT2_I(inode)->xattr_sem);\n" "So I think ext2_xattr_get should do in the same way.\n" @@ -80,4 +81,4 @@ "Thanks and Regards,\n" shenghui -f05093b425e4126e14a8b0217c22f698835d5fa9a312aecd04247cfb9d4b7f42 +1ada10975fca36ca0098be0321883921bfdd008522ac6854ca95fe97c8ce288d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.