From: Randy Dunlap <randy.dunlap@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] fix staging/spectra: removes q->prepare_flush_fn
Date: Tue, 13 Jul 2010 18:33:11 +0000 [thread overview]
Message-ID: <4C3CB167.4040702@oracle.com> (raw)
In-Reply-To: <1278732312.1725.17.camel@lenovo>
On 07/09/10 20:25, Javier Martinez Canillas wrote:
> This patch is the first one of a patchset that allows
> stagin/spectra driver to compile in linux-next.
>
> blk_queue_ordered doesn't receive a prepare flush function anymore
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
These 3 patches fix the build errors.
There are still some warnings that should be addressed.
Thanks.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/staging/spectra/ffsport.c | 10 +---------
> 1 files changed, 1 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/spectra/ffsport.c b/drivers/staging/spectra/ffsport.c
> index d0c5c97..eca6536 100644
> --- a/drivers/staging/spectra/ffsport.c
> +++ b/drivers/staging/spectra/ffsport.c
> @@ -272,13 +272,6 @@ static int get_res_blk_num_os(void)
> return res_blks;
> }
>
> -static void SBD_prepare_flush(struct request_queue *q, struct request *rq)
> -{
> - rq->cmd_type = REQ_TYPE_LINUX_BLOCK;
> - /* rq->timeout = 5 * HZ; */
> - rq->cmd[0] = REQ_LB_OP_FLUSH;
> -}
> -
> /* Transfer a full request. */
> static int do_transfer(struct spectra_nand_dev *tr, struct request *req)
> {
> @@ -650,8 +643,7 @@ static int SBD_setup_device(struct spectra_nand_dev *dev, int which)
> /* Here we force report 512 byte hardware sector size to Kernel */
> blk_queue_logical_block_size(dev->queue, 512);
>
> - blk_queue_ordered(dev->queue, QUEUE_ORDERED_DRAIN_FLUSH,
> - SBD_prepare_flush);
> + blk_queue_ordered(dev->queue, QUEUE_ORDERED_DRAIN_FLUSH);
>
> dev->thread = kthread_run(spectra_trans_thread, dev, "nand_thd");
> if (IS_ERR(dev->thread)) {
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-07-13 18:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 3:25 [PATCH 1/3] fix staging/spectra: removes q->prepare_flush_fn Javier Martinez Canillas
2010-07-13 18:33 ` Randy Dunlap [this message]
2010-07-16 1:24 ` Javier Martinez Canillas
2010-07-16 14:14 ` Randy Dunlap
2010-07-16 14:28 ` David Woodhouse
2010-07-17 20:26 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3CB167.4040702@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.