All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/9] stkutil: display text attributes as html
Date: Tue, 13 Jul 2010 15:38:07 -0500	[thread overview]
Message-ID: <4C3CCEAF.9070101@gmail.com> (raw)
In-Reply-To: <1279024855-10586-2-git-send-email-kristen@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Hi Kristen,
> +	/* add any color */
> +	if (fg)
> +		g_string_append_printf(string, "color: %s;", html_colors[fg]);
> +	if (bg)
> +		g_string_append_printf(string, "background-color: %s;",
> +						html_colors[bg]);

I applied the patch however I changed this part afterward.  Black
background / foreground should still be set explicitly.

Regards,
-Denis

  reply	other threads:[~2010-07-13 20:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-13 12:40 [PATCH 0/9] html text attribute patches Kristen Carlson Accardi
2010-07-13 12:40 ` [PATCH 1/9] stkutil: display text attributes as html Kristen Carlson Accardi
2010-07-13 20:38   ` Denis Kenzior [this message]
2010-07-13 12:40 ` [PATCH 2/9] test-stkutil: add unit test for html text attributes Kristen Carlson Accardi
2010-07-13 20:38   ` Denis Kenzior
2010-07-13 12:40 ` [PATCH 3/9] test-stkutil: add html attribute test for Display Text tests Kristen Carlson Accardi
2010-07-13 12:40 ` [PATCH 4/9] test-stkutil: add html attribute tests for get_inkey_test Kristen Carlson Accardi
2010-07-13 12:40 ` [PATCH 5/9] test-stkutil: add html attribute tests for get_input_test Kristen Carlson Accardi
2010-07-13 12:40 ` [PATCH 6/9] test-stkutil: add html attribute tests for play_tone_test Kristen Carlson Accardi
2010-07-13 12:40 ` [PATCH 7/9] test-stkutil: add html attribute test for setup_menu_test Kristen Carlson Accardi
2010-07-13 12:40 ` [PATCH 8/9] test-stkutil: add html attribute test for select_item_test Kristen Carlson Accardi
2010-07-13 12:40 ` [PATCH 9/9] test-stkutil: add html attribute tests for setup idle mode tests Kristen Carlson Accardi
  -- strict thread matches above, loose matches on Subject: below --
2010-07-02 13:45 [PATCH 0/9] html text attribute patches Kristen Carlson Accardi
2010-07-02 13:46 ` [PATCH 1/9] stkutil: display text attributes as html Kristen Carlson Accardi
2010-07-08 22:49   ` Denis Kenzior
2010-07-09 21:58     ` Kristen Carlson Accardi
2010-07-09 22:13       ` Denis Kenzior
2010-07-09 22:26         ` Kristen Carlson Accardi
2010-07-13 15:00           ` Denis Kenzior
2010-07-15 20:17       ` andrzej zaborowski
2010-07-15 20:32         ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C3CCEAF.9070101@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.