From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH]ata:ahci.c Fix warning: comparison between 'enum ' and 'enum ' Date: Wed, 14 Jul 2010 03:51:57 -0400 Message-ID: <4C3D6C9D.7070708@pobox.com> References: <1278167365-16011-1-git-send-email-justinmattock@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-gw0-f46.google.com ([74.125.83.46]:62702 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753124Ab0GNHwA (ORCPT ); Wed, 14 Jul 2010 03:52:00 -0400 Received: by mail-gw0-f46.google.com with SMTP id 18so3212470gwj.19 for ; Wed, 14 Jul 2010 00:52:00 -0700 (PDT) In-Reply-To: <1278167365-16011-1-git-send-email-justinmattock@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: "Justin P. Mattock" Cc: linux-ide@vger.kernel.org, tj@kernel.org On 07/03/2010 10:29 AM, Justin P. Mattock wrote: > The below patch casts ATA_MAX_QUEUE to int because GCC will > give a warning message about the two different enum blocks: > CC drivers/ata/ahci.o > drivers/ata/ahci.c: In function 'ahci_init_one': > drivers/ata/ahci.c:1045:2: warning: comparison between 'enum' and 'enum' > > Signed-off-by: Justin P. Mattock > > --- > drivers/ata/ahci.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index f252253..fe75d8b 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -1042,7 +1042,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > > VPRINTK("ENTER\n"); > > - WARN_ON(ATA_MAX_QUEUE> AHCI_MAX_CMDS); > + WARN_ON((int)ATA_MAX_QUEUE> AHCI_MAX_CMDS); > applied