From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yu Zhiguo <yuzg@cn.fujitsu.com>
Subject: Re: [PATCH] Don't attach needless options when launch
	pygrub
Date: Wed, 14 Jul 2010 18:21:46 +0800
Message-ID: <4C3D8FBA.1040602@cn.fujitsu.com>
References: <4C3D55F8.9010303@cn.fujitsu.com>		<1279090052.13417.16.camel@localhost.localdomain>		<4C3D6755.3020400@cn.fujitsu.com>		<1279095028.24714.186.camel@zakaz.uk.xensource.com>		<4C3D8514.6040901@cn.fujitsu.com>	<1279100788.24714.196.camel@zakaz.uk.xensource.com>
	<4C3D8C4F.7090400@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4C3D8C4F.7090400@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Yu Zhiguo wrote:
> Ian Campbell wrote:
>>>> So it looks like specifying the kernel option in addition to bootloader
>>>> is infact useful if you are booting a Solaris or Netware domU but is
>>>> harmless/ignored otherwise. I think we need to continue to support this
>>>  It seems that incfg will be returned directly if DomU is not Solaris,
>>>
>>> def sniff_solaris(fs, cfg):
>>>     if not fs.file_exists("/platform/i86xpv/kernel/unix"):
>>>         return cfg
>>>
>>>
>>>     chosencfg = sniff_solaris(fs, incfg)
>>>
>>>  So, incfg change to chosencfg and then will be used.
>> Oh yes, this stuff seems needlessly complex, or at least prone to
>> misreading, by me at least ;-)
>>
> 
>  OK, I'll try to fix this point.
> 
>>>  What about copy the specified 'kernel' from DomU to a temp file.
>>> If there are 'bootloader' but no 'kernel', pygrub will copy and create temp file.
>>> We can do the same things.
>> I think this is the current behaviour.
>>
>> Ian.
>>
> 
>  Oh, yes. It seems that path of specified 'kernel' will be checked 
> in configure_image(). We can delete this check if 'bootloader' is
> existent.

delete -> not do.
Because in this case, the path of 'kernel' is in DomU rather than Dom0.
Otherwise, xm create will break here.

Yu