From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu Zhiguo Subject: Re: [PATCH] Don't attach needless options when launch pygrub Date: Wed, 14 Jul 2010 19:01:46 +0800 Message-ID: <4C3D991A.4040104@cn.fujitsu.com> References: <4C3D55F8.9010303@cn.fujitsu.com> <1279090052.13417.16.camel@localhost.localdomain> <4C3D6755.3020400@cn.fujitsu.com> <1279095028.24714.186.camel@zakaz.uk.xensource.com> <4C3D8514.6040901@cn.fujitsu.com> <1279100788.24714.196.camel@zakaz.uk.xensource.com> <4C3D8C4F.7090400@cn.fujitsu.com> <1279102937.24714.240.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1279102937.24714.240.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Ian Campbell wrote: > On Wed, 2010-07-14 at 11:07 +0100, Yu Zhiguo wrote: >> Oh, yes. It seems that path of specified 'kernel' will be checked >> in configure_image(). We can delete this check if 'bootloader' is >> existent. > > That's only for kernel specified on the xm command line, not from the > configuration file, isn't it? > > I just confirmed that for a guest with grub configuration entries for > 2.6.32-5-686-bigmem and 2.6.26-2-686-bigmem (in that order) then > > bootloader = "/usr/bin/pygrub" > bootloader_args = "--quiet" > > kernel = "/boot/vmlinuz-2.6.26-2-686-bigmem" > ramdisk = "/boot/initrd.img-2.6.26-2-686-bigmem" > > will boot 2.6.26-2-686-bigmem whereas without the kernel and ramdisk > lines it will boot 2.6.32-5-686-bigmem. > I guess this DomU's grub.conf must has "kernel /boot/vmlinuz-2.6.26-2-686-bigmem". In other words, path of specified 'kernel' must be existent and *same* in both Dom0 and DomU. This is a problem, it is difficult for using. I want to resolve this by using 'kernel' as DomU's kernel path, so it should not check it is existent or not in Dom0. Yu >> What's your opinion? > > This is long standing behaviour of the toolstack and although it's a > little odd it's not totally useless (it could be very useful if you > botch you grub configuration for example). > > I'll ask again, what do you think is wrong with the current behaviour > and what are the benefits to changing it? > > Ian. > > > > > > >