From: Patrick McHardy <kaber@trash.net>
To: Simon Horman <horms@verge.net.au>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [patch] netfilter: default to NF_DROP in sip_help_tcp()
Date: Wed, 14 Jul 2010 14:23:01 +0200 [thread overview]
Message-ID: <4C3DAC25.3050401@trash.net> (raw)
In-Reply-To: <20100710031604.GA26990@verge.net.au>
On 10.07.2010 05:16, Simon Horman wrote:
> I initially noticed this because of the compiler warning below, but it does
> seem to be a valid concern in the case where ct_sip_get_header() returns 0
> in the first iteration of the while loop.
>
> net/netfilter/nf_conntrack_sip.c: In function 'sip_help_tcp':
> net/netfilter/nf_conntrack_sip.c:1379: warning: 'ret' may be used uninitialized in this function
Thanks Simon. I've applied the patch, but changed NF_DROP to
NF_ACCEPT since we should avoid dropping packets with unknown
contents (not SIP) if possible.
next prev parent reply other threads:[~2010-07-14 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 3:16 [patch] netfilter: default to NF_DROP in sip_help_tcp() Simon Horman
2010-07-14 12:23 ` Patrick McHardy [this message]
2010-07-14 12:38 ` Simon Horman
2010-08-04 8:07 ` Simon Horman
2010-08-04 16:10 ` Patrick McHardy
2010-08-05 0:34 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3DAC25.3050401@trash.net \
--to=kaber@trash.net \
--cc=horms@verge.net.au \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.