From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OZ13X-0001BO-EN for mharc-grub-devel@gnu.org; Wed, 14 Jul 2010 08:27:19 -0400 Received: from [140.186.70.92] (port=48133 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZ13U-00019x-Fb for grub-devel@gnu.org; Wed, 14 Jul 2010 08:27:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OZ13S-000567-RP for grub-devel@gnu.org; Wed, 14 Jul 2010 08:27:16 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:55162) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ13S-00055n-KK for grub-devel@gnu.org; Wed, 14 Jul 2010 08:27:14 -0400 Received: by bwz9 with SMTP id 9so4735438bwz.0 for ; Wed, 14 Jul 2010 05:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=Q6tQXsS0uq5yOFL1lQ4TS4HyiHvIV0Wj/4eOTSTvUFc=; b=V3LXS8LlKHydlK7geHfprCurnOhn9WUK8K6NWowgxYWo3k2oobhi4nuW7vnbEAjOj9 TQUZPU6DwV9KW3585iYH9l1fVVk4mtHRrzczkF/Rokj9x19vfS6J6mi9lG0xGPNESj7d TrSLkxx0y124hMgs0Nhrzo7JvmLsdsMyen77g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=EIhWik8nRbJUHwvkt+8OehFFKbXvrIZO+UBNdWKWgINTdZDOSHo+LQOHtI60n+XAS0 y7AIimqSF0ZG0UT0xKPwAKt3Ric9AStl6IxHYZi22u/F74vMY/2zlU7rvlhh/7cWOBU+ J48x/H2I4QrwTPtl5zglOeb1oHnq8KI9j06Hs= Received: by 10.204.72.209 with SMTP id n17mr4237299bkj.52.1279110432163; Wed, 14 Jul 2010 05:27:12 -0700 (PDT) Received: from debian.bg45.phnet (vpn-global-dhcp3-168.ethz.ch [129.132.210.168]) by mx.google.com with ESMTPS id y27sm32457886bkw.14.2010.07.14.05.27.10 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 14 Jul 2010 05:27:11 -0700 (PDT) Message-ID: <4C3DAD15.5030700@gmail.com> Date: Wed, 14 Jul 2010 14:27:01 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100620 Icedove/3.0.5 MIME-Version: 1.0 To: grub-devel@gnu.org References: <20100713054523.GC10155@kryten> <4C3C3018.3080508@gmail.com> <20100713101242.GA15491@kryten> In-Reply-To: <20100713101242.GA15491@kryten> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigDEF999264AFF59A64E4770F2" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Fix for relocatable PowerPC kernels X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2010 12:27:17 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDEF999264AFF59A64E4770F2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/13/2010 12:12 PM, Anton Blanchard wrote: > Hi, > > =20 >> Is building as ET_DYN supported upstream? We previously had reports of= >> building system of some distros to be plainly borked and usualy the >> distro fixed their building system pretty fast. If upstream supports >> ET_DYN, then this patch is accepted with no further questions. But if >> it's a borked building system it may have subtle bugs and allowing it >> would probably just suppress an early symptom of other problems. >> =20 > This is supported upstream on a number of architectures, for example > the PowerPC configuration option is: > > =20 Then I'm ok with your patch but I'm on wacky connection and don't want to risk a stale lock (unfortunately bzr-ssh isn't supported on savannah). Could someone with good access commit it? > config RELOCATABLE > bool "Build a relocatable kernel" > help > This builds a kernel image that is capable of running anywher= e > in the RMA (real memory area) at any 16k-aligned base address= =2E > The kernel is linked as a position-independent executable (PI= E) > and contains dynamic relocations which are processed early > in the bootup process. > > One use is for the kexec on panic case where the recovery ker= nel > must live at a different physical address than the primary > kernel. > > Regards, > Anton > > =20 >>> 2010-07-13 Anton Blanchard >>> >>> * loader/powerpc/ieee1275/linux.c (grub_cmd_linux): Do not reject >>> ET_DYN files. >>> >>> Index: grub/loader/powerpc/ieee1275/linux.c >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- grub.orig/loader/powerpc/ieee1275/linux.c 2010-07-11 12:05:16.443= 242734 +1000 >>> +++ grub/loader/powerpc/ieee1275/linux.c 2010-07-12 14:56:20.30199106= 5 +1000 >>> @@ -220,7 +220,7 @@ grub_cmd_linux (grub_command_t cmd __att >>> if (! elf) >>> goto out; >>> =20 >>> - if (elf->ehdr.ehdr32.e_type !=3D ET_EXEC) >>> + if (elf->ehdr.ehdr32.e_type !=3D ET_EXEC && elf->ehdr.ehdr32.e_typ= e !=3D ET_DYN) >>> { >>> grub_error (GRUB_ERR_UNKNOWN_OS, >>> "this ELF file is not of the right type"); >>> =20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigDEF999264AFF59A64E4770F2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkw9rRUACgkQNak7dOguQgnsmgEApqdFVaeRyLPWNchlqrf3+z1V 7ddtignx484kwk/LYwUBAIP4hAMDpOJBoizZi2hR6pYswiYVUkoM8+bbEYciaBLc =rOwI -----END PGP SIGNATURE----- --------------enigDEF999264AFF59A64E4770F2--