From: Jeremy Fitzhardinge <jeremy@goop.org>
To: David Miller <davem@davemloft.net>
Cc: pthakkar@vmware.com, pv-drivers@vmware.com, greg@kroah.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, hch@infradead.org,
netdev@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3
Date: Wed, 14 Jul 2010 11:03:17 -0700 [thread overview]
Message-ID: <4C3DFBE5.2020705@goop.org> (raw)
In-Reply-To: <20100714.105423.226778756.davem@davemloft.net>
On 07/14/2010 10:54 AM, David Miller wrote:
> And doing what you're doing is foolish on so many levels. One more
> duplication of code, one more place for unnecessary bugs to live, one
> more place that might need optimizations and thus require duplication
> of even more work people have done over the years.
>
Not to mention calling a function "MoveMemory" when it doesn't do a
memmove is just cruel.
J
next prev parent reply other threads:[~2010-07-14 18:03 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 23:02 RFC: Network Plugin Architecture (NPA) for vmxnet3 Pankaj Thakkar
2010-05-05 0:05 ` Stephen Hemminger
2010-05-05 0:05 ` Stephen Hemminger
2010-05-05 0:18 ` Pankaj Thakkar
2010-05-05 0:18 ` Pankaj Thakkar
2010-05-05 0:32 ` David Miller
2010-05-05 0:32 ` David Miller
2010-05-05 0:38 ` Pankaj Thakkar
2010-05-05 0:38 ` Pankaj Thakkar
2010-05-05 2:44 ` Stephen Hemminger
2010-05-05 2:44 ` Stephen Hemminger
2010-05-05 0:58 ` Chris Wright
2010-05-05 0:58 ` Chris Wright
2010-05-05 19:00 ` Pankaj Thakkar
2010-05-05 19:00 ` Pankaj Thakkar
2010-05-05 17:23 ` Christoph Hellwig
2010-05-05 17:23 ` Christoph Hellwig
2010-05-05 17:29 ` [Pv-drivers] " Dmitry Torokhov
2010-05-05 17:31 ` Christoph Hellwig
2010-05-05 17:35 ` Dmitry Torokhov
2010-05-05 17:39 ` Christoph Hellwig
2010-05-05 17:39 ` Christoph Hellwig
2010-05-05 17:47 ` Pankaj Thakkar
2010-05-05 17:47 ` Pankaj Thakkar
2010-05-05 20:09 ` Arnd Bergmann
2010-05-05 20:09 ` Arnd Bergmann
2010-05-05 20:36 ` Dmitry Torokhov
2010-05-05 20:36 ` Dmitry Torokhov
2010-05-05 21:53 ` Arnd Bergmann
2010-05-05 22:05 ` Shreyas Bhatewara
2010-05-06 2:03 ` Scott Feldman
2010-05-06 2:03 ` Scott Feldman
2010-05-06 7:25 ` Shreyas Bhatewara
2010-05-06 7:25 ` Shreyas Bhatewara
2010-05-06 7:25 ` Shreyas Bhatewara
2010-05-06 7:25 ` Shreyas Bhatewara
2010-05-05 22:05 ` Shreyas Bhatewara
2010-05-05 21:53 ` Arnd Bergmann
2010-05-06 8:19 ` Gleb Natapov
2010-05-06 18:04 ` Pankaj Thakkar
2010-05-06 18:04 ` Pankaj Thakkar
2010-05-06 20:19 ` Christoph Hellwig
2010-05-06 20:19 ` Christoph Hellwig
2010-05-06 8:19 ` Gleb Natapov
2010-05-06 20:17 ` Christoph Hellwig
2010-05-06 20:17 ` Christoph Hellwig
2010-05-05 17:52 ` Stephen Hemminger
2010-05-05 17:52 ` Stephen Hemminger
2010-05-06 20:21 ` Christoph Hellwig
2010-07-13 3:06 ` Shreyas Bhatewara
2010-07-13 3:06 ` Shreyas Bhatewara
2010-07-13 5:16 ` Stephen Hemminger
2010-07-13 5:16 ` Stephen Hemminger
2010-07-14 0:31 ` Stephen Hemminger
2010-07-14 0:31 ` Stephen Hemminger
2010-07-14 9:49 ` Greg KH
2010-07-14 9:49 ` Greg KH
2010-07-14 17:18 ` Pankaj Thakkar
2010-07-14 17:18 ` Pankaj Thakkar
2010-07-14 17:54 ` David Miller
2010-07-14 18:03 ` Jeremy Fitzhardinge
2010-07-14 18:03 ` Jeremy Fitzhardinge [this message]
2010-07-14 17:54 ` David Miller
2010-07-14 20:20 ` Greg KH
2010-07-14 20:20 ` Greg KH
2010-07-14 17:19 ` Shreyas Bhatewara
2010-07-14 17:19 ` Shreyas Bhatewara
2010-07-14 20:42 ` Shreyas Bhatewara
2010-07-14 20:42 ` Shreyas Bhatewara
2010-07-14 21:06 ` Greg KH
2010-07-14 21:06 ` Greg KH
2010-05-06 20:21 ` Christoph Hellwig
2010-05-05 17:35 ` Dmitry Torokhov
2010-05-05 17:31 ` Christoph Hellwig
2010-05-05 17:29 ` Dmitry Torokhov
2010-05-05 17:59 ` Avi Kivity
2010-05-05 17:59 ` Avi Kivity
2010-05-05 19:44 ` Pankaj Thakkar
2010-05-05 19:44 ` Pankaj Thakkar
2010-05-06 8:58 ` Avi Kivity
2010-05-06 8:58 ` Avi Kivity
2010-05-10 20:46 ` Pankaj Thakkar
2010-05-10 20:46 ` Pankaj Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3DFBE5.2020705@goop.org \
--to=jeremy@goop.org \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pthakkar@vmware.com \
--cc=pv-drivers@vmware.com \
--cc=shemminger@vyatta.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.