From: Wolfgang Grandegger <wg@grandegger.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: linux-mips@linux-mips.org, Wolfgang Grandegger <wg@denx.de>
Subject: Re: [PATCH v2] mips/alchemy: add basic support for the GPR board
Date: Wed, 14 Jul 2010 21:26:10 +0200 [thread overview]
Message-ID: <4C3E0F52.9090201@grandegger.com> (raw)
In-Reply-To: <AANLkTilwt8Eh9on0tjXecINx28ix1Bky8GiS-E4QdyIJ@mail.gmail.com>
On 07/14/2010 04:51 PM, Manuel Lauss wrote:
> On Wed, Jul 14, 2010 at 3:47 PM, Wolfgang Grandegger <wg@grandegger.com> wrote:
>> diff --git a/arch/mips/alchemy/gpr/board_setup.c b/arch/mips/alchemy/gpr/board_setup.c
>> new file mode 100644
>> index 0000000..4e68d76
>> --- /dev/null
>> +++ b/arch/mips/alchemy/gpr/board_setup.c
>
>> +static int __init gpr_init_irq(void)
>> +{
>> + return 0;
>> +}
>> +arch_initcall(gpr_init_irq);
>
> Seems superfluous. Do you intend to add something here in the future?
Well, as PCMCIA is not supported on that board, it's actually not
needed. I will remove and it for v3.
Wolfgang.
next prev parent reply other threads:[~2010-07-14 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 13:47 [PATCH v2] mips/alchemy: add basic support for the GPR board Wolfgang Grandegger
2010-07-14 14:51 ` Manuel Lauss
2010-07-14 19:26 ` Wolfgang Grandegger [this message]
2010-07-14 18:40 ` Florian Fainelli
2010-07-15 9:04 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3E0F52.9090201@grandegger.com \
--to=wg@grandegger.com \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@googlemail.com \
--cc=wg@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.