From: A Large Angry SCM <gitzilla@gmail.com>
To: Brock Peabody <brock.peabody@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: help with distributed workflow/signoff
Date: Wed, 14 Jul 2010 19:20:14 -0400 [thread overview]
Message-ID: <4C3E462E.9010205@gmail.com> (raw)
In-Reply-To: <loom.20100714T232116-579@post.gmane.org>
On 07/14/2010 05:46 PM, Brock Peabody wrote:
> Ævar Arnfjörð Bjarmason<avarab<at> gmail.com> writes:
>
>> Well, consider that even if you push most patches through, the peer
>> review you get from having a setup similar to Git's own might very
>> well be worth it. Everyone makes mistakes, having a second set of
>> eyeballs to look at your code eliminates a lot of that.
>>
>> That may not be acceptable to your corporate culture, but consider
>> that most big corporations (e.g. Google) do detailed code review
>> before anything gets commited to the master repository.
>
> Yes, that's a good point. We are trying to improve our code review processes,
> and I think switching to git is going to help with that down the road. I don't
> want to make the switch to git and a heavier (if better) process at the same
> time, however, as it would decrease the chance of either being accepted.
Have you investigated Gerrit Code Review?
next prev parent reply other threads:[~2010-07-14 23:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 16:33 help with distributed workflow/signoff Brock Peabody
2010-07-14 17:16 ` Jonathan Nieder
2010-07-14 17:49 ` Brock Peabody
2010-07-14 17:24 ` Avery Pennarun
2010-07-14 18:06 ` Brock Peabody
2010-07-14 21:03 ` Ævar Arnfjörð Bjarmason
2010-07-14 21:46 ` Brock Peabody
2010-07-14 23:20 ` A Large Angry SCM [this message]
2010-07-15 17:42 ` Brock Peabody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3E462E.9010205@gmail.com \
--to=gitzilla@gmail.com \
--cc=brock.peabody@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.